Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything icy related to make Clij3 compile #64

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

carlosuc3m
Copy link
Member

HEllo @StRigaud this branch removes everything Icy related from clesperanto, which is now in a separate branch (https://github.com/clEsperanto/clesperantoj_prototype/tree/icy-backup).

I have tried pulling your branch from clij3 and doing mvn clean install and now it works.
There are only a couple of changes needed on the clij3 pom.xml:

Also, in order to make the YEtAnotherPlayground2.java work, we need to add the version to the ImgLib2 dependency.-
Currently there is no version, as it overrides the one from he scijava pom (6.3.0), but clesperanto needs version 7.0.2

<version>7.0.2</version>

I hope this is works with clij3 for you too!

@carlosuc3m
Copy link
Member Author

Also this branch has the version 0.12.1 of clic hardcoded

@StRigaud
Copy link
Member

Thanks @carlosuc3m

I will update the clij3 and test on my side also.

I let you have a look at the failing test. And I merge this asap

@carlosuc3m carlosuc3m linked an issue Sep 11, 2024 that may be closed by this pull request
@carlosuc3m
Copy link
Member Author

The error seesm related to a memory limitation of the hosted runners. I have added a line in the pom.xml that allows the process to use more memory but maybe what we could do is to test for less versions of java. Currently we tests for 8, 11, 17 and 21. With 8 and 17 we could be fine, or even 8, 17 and 21

@StRigaud
Copy link
Member

maybe what we could do is to test for less versions of java. Currently we tests for 8, 11, 17 and 21. With 8 and 17 we could be fine, or even 8, 17 and 21

We can create an issue for this and see later what is needed

I merge, thanks again Carlos!

@StRigaud StRigaud merged commit edfb35b into main Sep 12, 2024
7 checks passed
@StRigaud StRigaud deleted the remove-icy branch September 20, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when executed in parallel
2 participants