Remove everything icy related to make Clij3 compile #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEllo @StRigaud this branch removes everything Icy related from clesperanto, which is now in a separate branch (https://github.com/clEsperanto/clesperantoj_prototype/tree/icy-backup).
I have tried pulling your branch from clij3 and doing
mvn clean install
and now it works.There are only a couple of changes needed on the clij3 pom.xml:
update the clesperantoj dependency name and version from clesperantoj_ to clesperantoj and from 0.0.0.1 to 0.0.1-SNAPSHOT
https://github.com/clEsperanto/clij3/blob/5fb98096f25a3e5c53a1a7f6d7baabef2aff6f0a/pom.xml#L128
remove the creator tag from the role node as it is not supported by scijava, maybe something like founder or owner exists.
https://github.com/clEsperanto/clij3/blob/5fb98096f25a3e5c53a1a7f6d7baabef2aff6f0a/pom.xml#L41
https://github.com/clEsperanto/clij3/blob/5fb98096f25a3e5c53a1a7f6d7baabef2aff6f0a/pom.xml#L53
Also, in order to make the YEtAnotherPlayground2.java work, we need to add the version to the ImgLib2 dependency.-
Currently there is no version, as it overrides the one from he scijava pom (6.3.0), but clesperanto needs version 7.0.2
clesperantoj_prototype/pom.xml
Line 154 in 3b7ff0d
I hope this is works with clij3 for you too!