-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add affine transforms #91
Conversation
This is super exciting @haesleinhuepf. Very promising, and I suspect affine transforms will be one of the most widely used parts of this library.
As mentioned in #90 (comment), I personally would love to see the API here match the existing python ecosystem APIs of I know you've had the discussion about explicitly naming axes in parameters elsewhere, but I definitely agree strongly with @jni in #49 (comment) that parameter names should not have any kind of implicit order. so I don't love I know all this takes more work, and I'm happy to start getting more involved here (after tying up some other things), but that would be my vote. |
What @tlambert03 said. 😄 Note also that in scikit-image/scikit-image#3544, I implemented that |
Hey Talley @tlambert03 and Juan @jni ,
this brings affine transforms to pyclesperanto + some convenience functions for scaling, rotation, translation and rigid transforms.
It doesn't support shearing for now (see #90 ) but I'm happy to add that later.
I would like to ask you to take a look at the API. It's more or less a re-implementation of the imglib2 / clij2 API. But if it makes sense, I'm happy to add additional optional parameters or functions to make it compatible to stuff in snake county. ;-)
Some interoperability is already available for scikit-image: The
cle.affine_transform()
function takes anskimage.transform.AffineTransform
astransform
parameter and converts it internally.You can take a look at API and its usage in this notebook.
Thanks a lot in advance!