Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(users/metadata) fix: next.js app router code and remove page router code #1758

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Dec 2, 2024

Warning

Should not be merged before #1750

Explanation:

  • Fix code examples

This PR:

  • Fix code paths, update Next.js App Router code examples, remove Page Router code

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@victoriaxyz victoriaxyz requested a review from a team as a code owner December 2, 2024 18:30
Copy link

github-actions bot commented Dec 2, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1758


export async function POST() {
const { stripeId, userId } = await body.json()
export async function POST(request: Request) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either use Request, Response or NextRequest, NextResponse in a single code example - but not both. apply to all examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexisintech alexisintech merged commit 86859fa into main Dec 3, 2024
4 checks passed
@alexisintech alexisintech deleted the vi/metadata-code branch December 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants