Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user-installation + DNSSEC disabling to DNS over Discord #16066

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add user-installation + DNSSEC disabling to DNS over Discord #16066

merged 1 commit into from
Oct 1, 2024

Conversation

MattIPv4
Copy link
Contributor

Summary

Update docs to match the upstream DNS over Discord docs, with user-installation (MattIPv4/DNS-over-Discord#89) + DNSSEC disabling (MattIPv4/DNS-over-Discord#65)

Screenshots (optional)

N/A

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@MattIPv4 MattIPv4 requested review from RebeccaTamachiro and a team as code owners August 12, 2024 02:42
@github-actions github-actions bot added the product:1.1.1.1 Related to 1.1.1.1 product label Aug 12, 2024
MattIPv4
MattIPv4 commented Aug 12, 2024
View reviewed changes
content/1.1.1.1/other-ways-to-use-1.1.1.1/dns-over-discord.md Outdated
@@ -5,7 +5,7 @@ title: DNS over Discord

# DNS over Discord

1.1.1.1 works from a Discord server, thanks to the 1.1.1.1 bot. [Invite the bot to your Discord server](https://cfl.re/3nM6VfQ) to start using DNS over Discord.
1.1.1.1 works from a Discord server, thanks to the 1.1.1.1 bot. [Invite the bot to your Discord server](https://cfl.re/3nM6VfQ) to start using DNS over Discord. Or, [add the bot to your Discord account](https://dns-over-discord.v4.wtf/invite/user) to use it anywhere in Discord.
Copy link
Contributor Author

@MattIPv4 MattIPv4 Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect https://discord.com/oauth2/authorize?client_id=613324904795996163&scope=applications.commands&integration_type=1 will want to be shortened to a new cfl.re URL, in replace of https://dns-over-discord.v4.wtf/invite/user?

content/1.1.1.1/other-ways-to-use-1.1.1.1/dns-over-discord.md Outdated
The bot can be invited at any time with [https://cfl.re/3nM6VfQ](https://cfl.re/3nM6VfQ).
The bot can also be added to accounts with [https://dns-over-discord.v4.wtf/invite/user](https://dns-over-discord.v4.wtf/invite/user).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal here, I imagine this will want a new cfl.re URL?

@MattIPv4 MattIPv4 mentioned this pull request Aug 12, 2024
Draft
@MattIPv4 MattIPv4 force-pushed the MattIPv4/dns-over-discord-user-install branch 2 times, most recently from d997e71 to 50a896b Compare August 13, 2024 20:18
@github-actions github-actions bot removed the product:1.1.1.1 Related to 1.1.1.1 product label Aug 13, 2024
@MattIPv4 MattIPv4 force-pushed the MattIPv4/dns-over-discord-user-install branch from 50a896b to e6f698d Compare August 19, 2024 02:48
@github-actions github-actions bot added the product:1.1.1.1 Related to 1.1.1.1 product label Aug 19, 2024
@KimJ15
Copy link
Collaborator

KimJ15 commented Sep 27, 2024

👋Hi there, we’re going to close this PR. All PRs prior to August 12 need to be reworked due to the platform migration to Astro.

@KimJ15 KimJ15 closed this Sep 27, 2024
@MattIPv4
Copy link
Contributor Author

MattIPv4 commented Sep 27, 2024 •
edited
Loading

👋 @KimJ15 I had already rebased the PR based on that :) Please reopen this

@KianNH KianNH reopened this Sep 27, 2024
KimJ15
KimJ15 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@KimJ15 KimJ15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KimJ15 KimJ15 merged commit 6528a11 into cloudflare:production Oct 1, 2024
11 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Oct 1, 2024
@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Oct 1, 2024

Congratulations @MattIPv4, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1qibf3f63040cjtbp6338oc

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

elithrar pushed a commit that referenced this pull request Oct 15, 2024
@MattIPv4 @elithrar
Add user-installation + DNSSEC disabling to DNS over Discord (#16066)
9028cee 
we have that bot in our Discord and those commands are functional
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
@MattIPv4 @maheshwarip
Add user-installation + DNSSEC disabling to DNS over Discord (#16066)
741bac9 
we have that bot in our Discord and those commands are functional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimJ15 KimJ15 KimJ15 approved these changes

@RebeccaTamachiro RebeccaTamachiro Awaiting requested review from RebeccaTamachiro RebeccaTamachiro is a code owner

Assignees

@RebeccaTamachiro RebeccaTamachiro

Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:1.1.1.1 Related to 1.1.1.1 product size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MattIPv4 @KimJ15 @RebeccaTamachiro @KianNH @workers-devprod