-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Analytics Engine #691
Open
cmackenzie1
wants to merge
4
commits into
cloudflare:main
Choose a base branch
from
cmackenzie1-contrib:cole/analytics-engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for Analytics Engine #691
cmackenzie1
wants to merge
4
commits into
cloudflare:main
from
cmackenzie1-contrib:cole/analytics-engine
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmackenzie1
force-pushed
the
cole/analytics-engine
branch
3 times, most recently
from
January 9, 2025 18:07
b00fc22
to
1a8a7d5
Compare
This one was a little tricky to add and requires mocking out the analytics engine binding using a miniflare wrapped binding that logs each datapoint to console. Resolves cloudflare#280, cloudflare#327 refactor: rename to match Typescript type names test: mock out analytics engine binding
cmackenzie1
force-pushed
the
cole/analytics-engine
branch
from
January 9, 2025 18:12
1a8a7d5
to
9f24b41
Compare
cmackenzie1
changed the title
WIP: Add support for Analytics Engine
Add support for Analytics Engine
Jan 9, 2025
zebp
reviewed
Jan 9, 2025
cmackenzie1
force-pushed
the
cole/analytics-engine
branch
from
January 10, 2025 05:09
5d60161
to
9a09313
Compare
@zebp since the type is |
Changes some of the API to be more flexible and remove the temporary `Vec` usage by using `Array` directly.
cmackenzie1
force-pushed
the
cole/analytics-engine
branch
from
January 10, 2025 05:11
9a09313
to
1f552a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a little tricky to add and requires mocking out the
analytics engine binding using a miniflare wrapped binding that logs
each data point to console.
Closes #280
Closes #327