Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve security by replacing random.choice with secrets.choice #37

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

lhhyung
Copy link
Member

@lhhyung lhhyung commented Dec 13, 2024

Improve security by replacing random.choice with secrets.choice

@lhhyung lhhyung self-assigned this Dec 13, 2024
Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 1 commits:

  • 3f8a4a5: refactor: Improve security by replacing random.choice with secrets.choice

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@lhhyung lhhyung added enhancement New feature or request and removed fail/signedoff labels Dec 13, 2024
@lhhyung lhhyung merged commit 4045928 into cloudforet-io:master Dec 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant