Fix issues caught in review

cloudfoundry · Oct 31, 2023 · c11e8d8 · c11e8d8
1 parent 000adca
commit c11e8d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/api/scaling-history-api.openapi.yaml b/api/scaling-history-api.openapi.yaml
@@ -51,7 +51,7 @@ paths:
       schema:
         type: string
         enum: ["asc", "desc"]
-        deprecated: true
+      deprecated: true
       example: order=desc
     - name: page
       in: query

diff --git a/src/autoscaler/api/publicapiserver/scaling_history_handler.go b/src/autoscaler/api/publicapiserver/scaling_history_handler.go
@@ -46,9 +46,9 @@ func NewScalingHistoryHandler(logger lager.Logger, conf *config.Config) (*Scalin
 
 func (h *ScalingHistoryHandler) NewError(_ context.Context, _ error) *scalinghistory.ErrorResponseStatusCode {
 	result := &scalinghistory.ErrorResponseStatusCode{}
-	result.SetStatusCode(500)
+	result.SetStatusCode(http.StatusInternalServerError)
 	result.SetResponse(scalinghistory.ErrorResponse{
-		Code:    scalinghistory.NewOptString(http.StatusText(500)),
+		Code:    scalinghistory.NewOptString(http.StatusText(http.StatusInternalServerError)),
 		Message: scalinghistory.NewOptString("Error retrieving scaling history from scaling engine"),
 	})
 	return result