fix(go_app): fix CPU usage by test app #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
silvestre
added
the
allow-acceptance-tests
silvestre
force-pushed
the
fix-cpu-usage-test-app
branch
from
334f2cc to
34f9d57
Compare
silvestre
force-pushed
the
fix-cpu-usage-test-app
branch
from
34f9d57 to
1400008
Compare
geigerj0
reviewed
Apr 2, 2024
geigerj0
approved these changes
Apr 2, 2024
- `min` is now builtin - `RWMutex` captures intent better
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The test app was not using the requested amount of CPU in all cases.
Cause
The main issue was that the main "busy loop", tasked with generating the synthetic CPU load, was interrupted too frequently to check if the overall test was done. This made it inaccurate.
Fix
The busy loop now runs uninterrupted for at least a second, which makes the check infrequent enough, so that it doesn't impact the CPU load.
Additionally, the unit tests were fixed, so that they actually test that the CPU is used as specified.