Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Correct Type Upon Binding Retrieval #3405

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Use Correct Type Upon Binding Retrieval #3405

merged 1 commit into from
Dec 9, 2024

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Dec 6, 2024 •
edited
Loading

Fix

Use Correct Type upon retrieval of binding

@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Dec 6, 2024
@asalan316 asalan316 force-pushed the improve-get-binding branch from 3fa35f5 to a6009d0 Compare December 6, 2024 12:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@asalan316 asalan316 changed the title use type instead of interface Use Correct Type Upon Binding Retrieval Dec 6, 2024
@asalan316 asalan316 marked this pull request as ready for review December 8, 2024 18:53
@asalan316 asalan316 added exclude-from-changelog allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed exclude-from-changelog allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Dec 8, 2024
salzmannsusan
salzmannsusan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@salzmannsusan salzmannsusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asalan316 asalan316 merged commit 4fe4f39 into main Dec 9, 2024
40 of 44 checks passed
@asalan316 asalan316 deleted the improve-get-binding branch December 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salzmannsusan salzmannsusan salzmannsusan approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. exclude-from-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asalan316 @salzmannsusan