Add astcatalog
and use it in gen-ast-pos
#256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new internal utility package named
astcatalog
.Package
astcatalog
provides a catalog of AST node types obtained fromast/ast.go
.This PR rewrites
gen-ast-pos
to useastcatalog
instead ofregexp
matching, and this PR also fixes some errors inast/ast.go
docs.Important changes for contributors:
ast.go
andast_*.go
as conventional. This means that these files are used for automatic generation (e.g.,gen-ast-pos
), and so we need to take care of the structures of these files.const.go
toast_const.go
.