Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new job for publishing docker image to GitHub Container Registry #111

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

sters
Copy link
Contributor

@sters sters commented Jul 16, 2024

WHAT

This PR adds a new CI job for publishing docker image to GitHub Container Registry in the release workflow.

You can confirm the result on my forked repo:

WHY

To provide a continuous build for the docker image related to releases.
And related to this comment: #97 (comment)

@sters
Copy link
Contributor Author

sters commented Jul 16, 2024

I don't know why CI is failed at Run make setup-emulator with this error:

make: *** [Makefile:25: setup-emulator] Error 56

In my forked repo, there is no problem.
https://github.com/sters/wrench/actions/runs/9958721943/job/27513780866

@sters
Copy link
Contributor Author

sters commented Jul 19, 2024

I don't know who can review on this repo... Maybe it's better to add CODEOWNER file.

Anyway, I think @shuheiktgw can do.
Could you check this PR when you have time?

Copy link
Collaborator

@zoncoen zoncoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work! LGTM

Copy link
Collaborator

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shuheiktgw shuheiktgw merged commit 9163374 into cloudspannerecosystem:master Aug 2, 2024
2 checks passed
@shuheiktgw
Copy link
Collaborator

It seems to work great 🎉
https://github.com/cloudspannerecosystem/wrench/pkgs/container/wrench

@sters
Copy link
Contributor Author

sters commented Aug 2, 2024

Thanks all!

@Shion1305
Copy link
Contributor

Thanks for implementing the workflow! I'll close #97

@comebackoneyear
Copy link

Would it be possible to add support for arm images? I'm using the github action runners linux/arm64/v8 but also m2 mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants