Locators,Action and Stepdesign class for hub #12
Conversation
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
6 times, most recently
from
1eef033 to
107421d
Compare
| */ | ||
| public class CdfHubLocators { | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//input[@class='search-input form-control'][@placeholder='Search by name']") |
There was a problem hiding this comment.
No need to write them here which is related to control center , how can we extract those locators from control center locator file ? so that duplicate code can be avoided ?
| } | ||
| @Then("Verify user can click on the delete icon of the plugin and plugin gets deleted successfully") | ||
| public void deleteControlCenterPlugin() { | ||
| CdfHubActions.deletePluginControlCenter(); |
There was a problem hiding this comment.
Where are we verifying that the plugin is actualy deleted after successful delete operation . Ideally we should be adding some validationsteps to search for the deleted plugin post delete
There was a problem hiding this comment.
added the validation step
| } | ||
|
|
||
| public static WebElement deleteButton() { | ||
| return SeleniumDriver.getDriver().findElement(By.xpath("//button[@class='btn btn-primary']" + |
There was a problem hiding this comment.
Change to //button[@data-cy='Delete'] or //button[@data-testid='Delete']
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
2282768 to
fdeef41
Compare
| public static WebElement deleteButton; | ||
| @FindBy(how = How.XPATH, using = "//button[@id='navbar-hub']") | ||
| public static WebElement hubPage; | ||
| @FindBy(how = How.XPATH, using = "//*[contains(text(),'No entities found in namespace \"default\"')]") |
There was a problem hiding this comment.
As discussed, check for 'No results found' text after deleting
There was a problem hiding this comment.
The text which we are getting there is No entities found.
| @FindBy(how = How.XPATH, using = "//button[@id='navbar-hub']") | ||
| public static WebElement hubPage; | ||
| @FindBy(how = How.XPATH, using = "//*[contains(text(),'No entities found in namespace \"default\"')]") | ||
| public static WebElement verifyDelete; |
There was a problem hiding this comment.
I think verifyDelete can be changed to something else specific to deletion of element like that?
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
741a14d to
a147e95
Compare
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
a147e95 to
811d0dd
Compare
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
c0592d1 to
47fb50b
Compare
No description provided.