E2E sqlengine ITN #53
Conversation
| BigQueryClient.getSoleQueryResult("create table `" + datasetName + "." + bqSourceTable2 + "` " + | ||
| "(customerid INT64, item STRING, price FLOAT64 )"); | ||
| try { | ||
| io.cdap.e2e.utils.BigQueryClient.getSoleQueryResult("INSERT INTO `" + datasetName + "." + bqSourceTable2 + "` " + |
| } | ||
|
|
||
| public static void enterAggregates(String jsonAggreegatesFields) { | ||
| Map<String, String> fieldsMapping = |
There was a problem hiding this comment.
Its a good practice to add a Java doc with Inline comments whenever you write a customized logic, please add the same.
| try { | ||
| ElementHelper.clickOnElement(SeleniumDriver.getDriver(). | ||
| findElement(CdfPluginPropertiesLocators.locateDropdownListItem | ||
| (entry.getKey().split("#")[1]))); |
There was a problem hiding this comment.
Fix the Indentation here.
| /** | ||
| * GroupBy Related Locators. | ||
| */ | ||
| public class GroupByLocators { |
There was a problem hiding this comment.
Why are we adding Group By Locators in bigquery module ?
There was a problem hiding this comment.
changed its module . created a separate module named groupby and added in that.
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package io.cdap.plugin.bigquery.stepsdesign; |
There was a problem hiding this comment.
Also Validation helper usually go in utils or common folder, are we adding Validation helpers in specific modules for other plugins as well ?
There was a problem hiding this comment.
No, we don't add in utils. We simply add them in module folder.
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(ValidationHelper.class); | ||
| static Gson gson = new Gson(); | ||
| public static boolean validateActualDataToExpectedData(String table, String fileName) throws IOException, |
There was a problem hiding this comment.
Same comment for these methods, add java doc and Inline comments.
AnkitCLI
force-pushed
the
e2e-sqlengine-ITN
branch
7 times, most recently
from
f2087f7 to
1d443bd
Compare
AnkitCLI
force-pushed
the
e2e-sqlengine-ITN
branch
from
1d443bd to
1bb71a8
Compare
AnkitCLI
force-pushed
the
e2e-sqlengine-ITN
branch
from
52aefc9 to
4c9217e
Compare
E2e tests covered as ITN for SqlEngine.