Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1199

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fix CI #1199

merged 2 commits into from
Dec 14, 2021

Conversation

edomora97
Copy link
Contributor

apt install may fail without a prior apt update.

If you accept this, this commit may also be cherry-picked in #1141 #1142 and #1198.

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #1199 (6dc9fbc) into master (c9d7e02) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   63.62%   63.48%   -0.14%     
==========================================
  Files         233      233              
  Lines       17131    17117      -14     
==========================================
- Hits        10899    10867      -32     
- Misses       6232     6250      +18     
Flag Coverage Δ
functionaltests 47.11% <ø> (-0.31%) ⬇️
unittests 44.10% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/db/util.py 52.59% <0.00%> (-5.19%) ⬇️
cms/server/contest/handlers/contest.py 82.52% <0.00%> (-3.89%) ⬇️
cms/io/priorityqueue.py 93.43% <0.00%> (-1.50%) ⬇️
cms/io/PsycoGevent.py 60.00% <0.00%> (-1.12%) ⬇️
cms/service/EvaluationService.py 72.63% <0.00%> (-1.00%) ⬇️
cms/db/filecacher.py 78.22% <0.00%> (-0.99%) ⬇️
cms/io/rpc.py 93.12% <0.00%> (-0.76%) ⬇️
cms/service/ProxyService.py 67.67% <0.00%> (-0.51%) ⬇️
cms/grading/steps/whitediff.py 87.87% <0.00%> (-0.36%) ⬇️
cms/io/triggeredservice.py 86.59% <0.00%> (-0.28%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d7e02...6dc9fbc. Read the comment docs.

@edomora97
Copy link
Contributor Author

I can't figure out why the tests now fail, in my fork they seem to succeed. Are they flacky? 🙈

Copy link
Member

@andreyv andreyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@andreyv
Copy link
Member

andreyv commented Dec 12, 2021

I can't figure out why the tests now fail, in my fork they seem to succeed. Are they flacky? see_no_evil

Hmm, I restarted the jobs and they now pass. I haven't seen these errors before. The failure messages hint at some pattern, but at a first look there's nothing out of line in the relevant tests.

> WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
@andreyv andreyv merged commit de5a0ca into cms-dev:master Dec 14, 2021
stefano-maggiolo pushed a commit to stefano-maggiolo/cms that referenced this pull request Dec 21, 2021
* Fix CI

* Use apt-get instead of apt

> WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
@edomora97 edomora97 deleted the fix/ci branch December 27, 2021 17:43
RezwanArefin01 pushed a commit to RezwanArefin01/cms that referenced this pull request Dec 27, 2021
* Fix CI

* Use apt-get instead of apt

> WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants