-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #1199
Fix CI #1199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 63.62% 63.48% -0.14%
==========================================
Files 233 233
Lines 17131 17117 -14
==========================================
- Hits 10899 10867 -32
- Misses 6232 6250 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I can't figure out why the tests now fail, in my fork they seem to succeed. Are they flacky? 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, official recommendation to use apt-get update
: https://docs.github.com/en/actions/using-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners
Hmm, I restarted the jobs and they now pass. I haven't seen these errors before. The failure messages hint at some pattern, but at a first look there's nothing out of line in the relevant tests. |
> WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
* Fix CI * Use apt-get instead of apt > WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
* Fix CI * Use apt-get instead of apt > WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
apt install
may fail without a priorapt update
.If you accept this, this commit may also be cherry-picked in #1141 #1142 and #1198.