Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alpaka] Make use of cms::alpakatools::ALPAKA_ACCELERATOR_NAMESPACE #241

Closed
wants to merge 11 commits into from
Closed

[alpaka] Make use of cms::alpakatools::ALPAKA_ACCELERATOR_NAMESPACE #241

wants to merge 11 commits into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 15, 2021

Move the accelerator-specific symbols from cms::alpakatools to cms::alpakatools::ALPAKA_ACCELERATOR_NAMESPACE.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 15, 2021

This PR includes #220 and #236, and is mostly to evaluate the feasibility of this approach.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 15, 2021

I also tried using ALPAKA_ACCELERATOR_NAMESPACE::cms::alpakatools, but the intermediate steps generated by NVCC were getting confused about the cms namespace being ambiguous when used from inside the ALPAKA_ACCELERATOR_NAMESPACE namespace.

@fwyzard fwyzard marked this pull request as draft October 15, 2021 21:18
@fwyzard fwyzard added the alpaka label Oct 15, 2021
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 15, 2021

This PR does not fix the crash in sortByPt2(...) nor the crash in the TBB backend.

@fwyzard fwyzard mentioned this pull request Oct 16, 2021
Merged
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 18, 2021

These changes are now included in #236 .

@fwyzard fwyzard closed this Oct 18, 2021
@fwyzard fwyzard deleted the ScopedContext+refactor_prefixScan+fix_accelerator_namespace branch October 18, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpaka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @antoniopetre @waredjeb