Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hls4mlEmulatorExtras to v1.1.4 #9606

Open
wants to merge 1 commit into
base: IB/CMSSW_15_0_X/master
Choose a base branch
from

Conversation

missirol
Copy link

Update of the hls4mlEmulatorExtras to v1.1.4 to include cms-hls4ml/hls4mlEmulatorExtras#6, which is required by cms-sw/cmssw#47070 to address cms-sw/cmssw#46740.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#47070

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-396d3c/43714/summary.html
COMMIT: 0ce0548
CMSSW: CMSSW_15_0_X_2025-01-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9606/43714/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-396d3c/43714/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-396d3c/43714/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreConcurrency had ERRORS

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818780
  • DQMHistoTests: Total failures: 126
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818634
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@missirol
Copy link
Author

The unit test failure does not seem related to this PR. In addition, I do not see any DQM differences that could be attributed to this PR (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants