[NGT] Fix double inclusion of Phase2HLTMuonSelectorForL3 module

[Parsifal-2045]

PR description:

This PR fixes the following error:

----- Begin Fatal Exception 07-Jan-2025 11:36:39 CET-----------------------
An exception of category 'WrongPluginLoaded' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'Phase2HLTMuonSelectorForL3' should have been loaded from
 '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02870/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-29-0000/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
 but instead it was already loaded from
 '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02870/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-29-0000/lib/el8_amd64_gcc12/pluginRecoMuonL3TrackFinderPlugins.so'
 because some other plugin was loaded from the latter loadables.
To work around the problem the plugin 'Phase2HLTMuonSelectorForL3' should only be defined in one of these loadables.
----- End Fatal Exception -------------------------------------------------

I first noticed this when developing on top of one of the latest IBs and then followed it in the past few IBs. The IB logs mostly detect it in the arm backend, but I've found the reported error when trying to run the 29850.778 workflow. Curiously, this issue is only present in the IBs: I have not been able to reproduce it starting from CMSSW_15_0_0_pre1 and just merging #46897.

PR validation:

I've tested the fix once again on 29834 and 29850 workflows with no modifiers as well as .777 and .778 in both cases. No such error is reported anymore.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47049/43194

[cmsbuild]

A new Pull Request was created by @Parsifal-2045 for master.

It involves the following packages:

• RecoMuon/L3TrackFinder (reconstruction, hlt)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @mmusich, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type ngt

[mmusich]

test parameters:

• workflow_opts= -w upgrade
• workflow = 29834.0, 29834.777, 29834.778, 29850.0, 29850.777, 29850.778
• enable = hlt_p2_integration, hlt_p2_timing

[mmusich]

@cmsbuild, please test

[mmusich]

type bug-fix

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d8776/43654/summary.html
COMMIT: 5c2080c
CMSSW: CMSSW_15_0_X_2025-01-07-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47049/43654/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

There are some workflows for which there are errors in the baseline:
29834.778 step 2
29850.778 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 71 lines to the logs
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4249454
• DQMHistoTests: Total failures: 839
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4248595
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 234 log files, 202 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• the workflows failing prior to this PR are now successful (see [NGT] Fix double inclusion of Phase2HLTMuonSelectorForL3 module  #47049 (comment))
• the whole package RecoMuon/L3TrackFinder could be reorganized such that all the plugins are actually in the plugins folder (and the SealModules.cc file is thus removed), but this can be followed up in another PR.

[mmusich]

the whole package RecoMuon/L3TrackFinder could be reorganized such that all the plugins are actually in the plugins folder (and the SealModules.cc file is thus removed),

commit mmusich@aae2698 offers an implementation (I tested it passes both runTheMatrix.py --what upgrade -l 29850.778 --ibeos and addOnTests).

[Parsifal-2045]

the whole package RecoMuon/L3TrackFinder could be reorganized such that all the plugins are actually in the plugins folder (and the SealModules.cc file is thus removed),

commit mmusich@aae2698 offers an implementation (I tested it passes both runTheMatrix.py --what upgrade -l 29850.778 --ibeos and addOnTests).

I would look into removing a bunch of SealModules at least from the Muon part of CMSSW in a separate PR

[jfernan2]

+1
Peding reorganization of SealModules in a separate PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1