Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove d-r-c and upgrade channels-redis #1688

Merged
merged 3 commits into from
Dec 5, 2024
Merged

remove d-r-c and upgrade channels-redis #1688

merged 3 commits into from
Dec 5, 2024

Conversation

bbearce
Copy link
Collaborator

@bbearce bbearce commented Dec 2, 2024

Description

channels-redis is having connectivity issues due to an old aioredis package it relies on. Since we aren't using django-redis-cache it has been removed. channels-redis and redis have been updated to replace old aioredis functionality

Issues this PR resolves

A checklist for hand testing

  • Run automated tests
  • I ran a test manually and it ran to completion

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Dec 3, 2024

@bbearce There is a conflict with poetry.lock (due to #1672)

@bbearce
Copy link
Collaborator Author

bbearce commented Dec 3, 2024

Ihsaan fixed merge conflict and I rebuilt the poetry.lock file. This PR is up to date with develop now.

@Didayolo Didayolo self-assigned this Dec 5, 2024
@Didayolo Didayolo linked an issue Dec 5, 2024 that may be closed by this pull request
@Didayolo
Copy link
Member

Didayolo commented Dec 5, 2024

@bbearce Do we need to re-build dockers when having an update? This applies also to the recent changes merged into master.

@Didayolo Didayolo merged commit 63a70b1 into develop Dec 5, 2024
1 check passed
@Didayolo Didayolo deleted the issue_1446 branch December 5, 2024 12:37
@bbearce
Copy link
Collaborator Author

bbearce commented Dec 5, 2024

To rebuild containers:

docker compose build && docker compose up -d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue congestion (public queue)
3 participants