Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix App Bar Icon Shrinking and Wrapper Overlapping with main contents Issues #1612

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Fix App Bar Icon Shrinking and Wrapper Overlapping with main contents Issues #1612

merged 3 commits into from
Dec 6, 2024

Conversation

rajveeerr
Copy link
Contributor

@rajveeerr rajveeerr commented Dec 5, 2024 •
edited
Loading

PR Fixes:

  • Fixed app bar icon sizing by setting the min-width to 3.7rem (previously, the width was set to 4vw with no min-width), leading to icons shrinking to an unusually small size.
  • Increased padding in the wrapper to resolve the overlapping issue between the app bar and buttons.

Before and After Screenshots

State Screenshot
Before Screenshot 2024-12-06 at 6 48 34 PM
After Screenshot 2024-12-06 at 6 47 07 PM

Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • I assure there is no similar/duplicate pull request regarding the same issue.

@devsargam @siinghd

@devsargam devsargam merged commit 364ce05 into code100x:main Dec 6, 2024
1 check failed
@devsargam
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajveeerr @devsargam