-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented form for reporting issues encountered while accessing the course #1712
base: main
Are you sure you want to change the base?
feat: Implemented form for reporting issues encountered while accessing the course #1712
Conversation
…or email notifications
@devsargam and @hkirat please look into this and suggest me any changes if needed |
@@ -0,0 +1,31 @@ | |||
import nodemailer from "nodemailer"; | |||
|
|||
const transporter = nodemailer.createTransport({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, gmail limits the number of emails that we can send over a day. So, we might reach that limit very easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but Gmail enforces daily email limits regardless of the method used (SMTP, web interface, or API). If we’re likely to hit these limits, then we have to switch to a scalable service like SendGrid for handling higher email volumes effectively.
src/app/api/send-email/route.ts
Outdated
import { NextResponse } from "next/server"; | ||
import { sendMail } from "@/lib/nodemailer"; | ||
|
||
export async function POST(req: Request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing authentication check here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added now
I will check with the team if this feature is needed or not and will update |
09cde3f
to
3643626
Compare
PR Fixes:
sendMail
function to include full user details.Note:
--- Just create app password from manage google and add it to the env file
Resolves #1711
Checklist before requesting a review
Before:
cursorful-video-1736890156227.mp4
After:
cursorful-video-1736892094746_2.mp4