Skip to content

Commit

Permalink
code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
JerrySentry committed Apr 26, 2024
1 parent a68a143 commit 10f0ac7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { LoadingTable } from '../../subroute/ComponentsTable/ComponentsTable'
function SyncingBanner() {
return (
<div className="grid gap-4 pt-4">
<LoadingTable></LoadingTable>
<LoadingTable />
<div className="flex flex-col items-center gap-1">
<Spinner />
<p>It might take up to 1 hour to view your data.</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function TriggerSyncBanner() {

return (
<div className="grid gap-4 pt-4">
<LoadingTable></LoadingTable>
<LoadingTable />
<div className="flex flex-col items-center gap-1">
<p>No data to display</p>
<p>You will need to enable components to see related coverage data.</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ interface BranchSelectorProps {
isDisabled: boolean | undefined
}

const BranchSelector: React.FC<BranchSelectorProps> = ({ isDisabled }) => {
const BranchSelector: React.FC<BranchSelectorProps> = ({
isDisabled = false,
}) => {
const { provider, owner, repo, branch } = useParams<URLParams>()
const { params, updateParams } = useLocationParams(defaultQueryParams)
const [branchSearchTerm, setBranchSearchTerm] = useState<string>('')
Expand Down

0 comments on commit 10f0ac7

Please sign in to comment.