Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Refactor and redesign TOS 1/3 #2300

Merged
merged 8 commits into from
Oct 12, 2023
Merged

ref: Refactor and redesign TOS 1/3 #2300

merged 8 commits into from
Oct 12, 2023

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Oct 4, 2023

Description

Refactor of TOS, this PR does not include changes to support service-less users, this is implementing the new design by:

  • Removing the default org selector
  • Refactor the form to unregister email input if user didn't give the marketing consent
  • Small CSS changes
  • Tests

Screenshots

Screen.Recording.2023-10-04.at.1.46.49.PM.mov

closes: codecov/engineering-team#374 & codecov/engineering-team#375

Still missing a logo

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Oct 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@aac290d). Click here to learn what that means.
The diff coverage is 88.88%.

❗ Current head 3c06bf7 differs from pull request most recent head 1d73ba6. Consider uploading reports for the commit 1d73ba6 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage        ?   97.79%           
=======================================
  Files           ?      706           
  Lines           ?     8220           
  Branches        ?     1931           
=======================================
  Hits            ?     8039           
  Misses          ?      179           
  Partials        ?        2           
Files Coverage Δ
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 100.00% <ø> (ø)
src/pages/TermsOfService/TermsOfService.jsx 97.36% <100.00%> (ø)
src/assets/svg/umbrella.svg 50.00% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac290d...1d73ba6. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 1d73ba6
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6527dbc530dccc0008d317b4
😎 Deploy Preview https://deploy-preview-2300--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2300 (1d73ba6) into main (aac290d) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2300     +/-   ##
=======================================
+ Coverage   34.40   34.44   +0.04     
=======================================
  Files        656     656             
  Lines       8087    8077     -10     
  Branches    1942    1941      -1     
=======================================
  Hits        2782    2782             
+ Misses      5282    5272     -10     
  Partials      23      23             
Files Coverage Δ
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 0.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 0.00% <ø> (ø)
src/pages/TermsOfService/TermsOfService.jsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac290d...1d73ba6. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 4, 2023

Codecov Report

Merging #2300 (1d73ba6) into main (aac290d) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
+ Coverage   34.40%   34.44%   +0.04%     
==========================================
  Files         656      656              
  Lines        8087     8077      -10     
  Branches     1942     1971      +29     
==========================================
  Hits         2782     2782              
+ Misses       5282     5266      -16     
- Partials       23       29       +6     
Files Coverage Δ
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 0.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 0.00% <ø> (ø)
src/pages/TermsOfService/TermsOfService.jsx 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac290d...1d73ba6. Read the comment docs.

@RulaKhaled RulaKhaled marked this pull request as ready for review October 4, 2023 11:52
@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 12, 2023

Codecov Report

Merging #2300 (1d73ba6) into main (aac290d) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
+ Coverage   34.40%   34.44%   +0.04%     
==========================================
  Files         656      656              
  Lines        8087     8077      -10     
  Branches     1975     1941      -34     
==========================================
  Hits         2782     2782              
+ Misses       5276     5272       -4     
+ Partials       29       23       -6     
Files Coverage Δ
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 0.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 0.00% <ø> (ø)
src/pages/TermsOfService/TermsOfService.jsx 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac290d...1d73ba6. Read the comment docs.

@RulaKhaled RulaKhaled merged commit acd0610 into main Oct 12, 2023
23 of 27 checks passed
@RulaKhaled RulaKhaled deleted the refactor-tos branch October 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref: Remove the old selector from TOS page
2 participants