-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolve infinite loop in coverage/analytics pages. #2307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
- Coverage 34.40% 34.38% -0.02%
==========================================
Files 656 656
Lines 8087 8087
Branches 1944 1942 -2
==========================================
- Hits 2782 2781 -1
- Misses 5282 5283 +1
Partials 23 23
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
- Coverage 34.40% 34.38% -0.02%
==========================================
Files 656 656
Lines 8087 8087
Branches 1992 1992
==========================================
- Hits 2782 2781 -1
- Misses 5276 5277 +1
Partials 29 29
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2307 +/- ##
=======================================
- Coverage 34.40 34.39 -0.01
=======================================
Files 656 656
Lines 8087 8087
Branches 1992 1942 -50
=======================================
- Hits 2782 2781 -1
- Misses 5276 5283 +7
+ Partials 29 23 -6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, maybe try re-running the CI to clean up the report 🤔
Description
looks like we were getting first of an undefined date, which caused the whole page to break and re-call the hook.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.