Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve infinite loop in coverage/analytics pages. #2307

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

RulaKhaled
Copy link
Contributor

Description

looks like we were getting first of an undefined date, which caused the whole page to break and re-call the hook.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 9, 2023

Codecov Report

Merging #2307 (6c1ed16) into main (1e765a3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2307      +/-   ##
==========================================
- Coverage   34.40%   34.38%   -0.02%     
==========================================
  Files         656      656              
  Lines        8087     8087              
  Branches     1944     1942       -2     
==========================================
- Hits         2782     2781       -1     
- Misses       5282     5283       +1     
  Partials       23       23              
Files Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.jsx 0.00% <0.00%> (ø)
...verageTab/subroute/CoverageChart/CoverageChart.jsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e765a3...6c1ed16. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 9, 2023

Codecov Report

Merging #2307 (6c1ed16) into main (1e765a3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2307      +/-   ##
==========================================
- Coverage   34.40%   34.38%   -0.02%     
==========================================
  Files         656      656              
  Lines        8087     8087              
  Branches     1992     1992              
==========================================
- Hits         2782     2781       -1     
- Misses       5276     5277       +1     
  Partials       29       29              
Files Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.jsx 0.00% <0.00%> (ø)
...verageTab/subroute/CoverageChart/CoverageChart.jsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e765a3...6c1ed16. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 6c1ed16
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/652509a43dbe4c0008c565cf
😎 Deploy Preview https://deploy-preview-2307--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2307 (6c1ed16) into main (1e765a3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2307     +/-   ##
=======================================
- Coverage   34.40   34.39   -0.01     
=======================================
  Files        656     656             
  Lines       8087    8087             
  Branches    1992    1942     -50     
=======================================
- Hits        2782    2781      -1     
- Misses      5276    5283      +7     
+ Partials      29      23      -6     
Files Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.jsx 0.00% <0.00%> (ø)
...verageTab/subroute/CoverageChart/CoverageChart.jsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e765a3...6c1ed16. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, maybe try re-running the CI to clean up the report 🤔

@RulaKhaled RulaKhaled merged commit aac290d into main Oct 10, 2023
23 of 29 checks passed
@RulaKhaled RulaKhaled deleted the resolve-infinite-loop branch October 10, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants