-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Update useCommit to Use New impactedFiles Resolver #2316
ref: Update useCommit to Use New impactedFiles Resolver #2316
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 97.42% 97.41% -0.01%
==========================================
Files 715 716 +1
Lines 8509 8519 +10
Branches 2089 2094 +5
==========================================
+ Hits 8290 8299 +9
- Misses 216 217 +1
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2316 +/- ##
=======================================
- Coverage 97.43 97.42 -0.01
=======================================
Files 715 716 +1
Lines 8509 8519 +10
Branches 2089 2087 -2
=======================================
+ Hits 8290 8299 +9
- Misses 216 217 +1
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 97.42% 97.41% -0.01%
==========================================
Files 715 716 +1
Lines 8509 8519 +10
Branches 2082 2087 +5
==========================================
+ Hits 8290 8299 +9
Misses 217 217
- Partials 2 3 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ted-files-resolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, side note one test failed maybe needs to resync with main to get those test suite updates?
src/pages/CommitDetailPage/CommitDetailPage.spec.jsx
line 207
…ted-files-resolver
Codecov Report
@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 97.42% 97.41% -0.01%
==========================================
Files 715 716 +1
Lines 8509 8519 +10
Branches 2040 2045 +5
==========================================
+ Hits 8290 8299 +9
- Misses 217 218 +1
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Description
This PR updates the current
useCommit
hook to use the updatedimpactedFiles
resolver so that we can continue working on adding flag selection support to the commit detail page.Closes codecov/engineering-team#673
Notable Changes
useCommit
to use the newimpactedFiles
resolverFilesChangedTable
to check for new__typename
instancesIndirectChangesTable
to check for new__typename
instancesUnkownFlags
schema type