Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Flags Query Param to Parent Commit Link in Commit Summary #2318

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Small PR just grabbing and appending any flags that are found in the query params.

Closes codecov/engineering-team#674

Notable Changes

  • Update CommitDetailSummary to pull flags query param and append to the parent commit link
  • Update tests

@codecov-qa
Copy link

codecov-qa bot commented Oct 18, 2023

Codecov Report

Merging #2318 (586b136) into main (00c8a85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2318   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8519     8525    +6     
  Branches     2087     2093    +6     
=======================================
+ Hits         8299     8305    +6     
+ Misses        218      217    -1     
- Partials        2        3    +1     
Files Coverage Δ
...ilPage/CommitDetailSummary/CommitDetailSummary.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c8a85...586b136. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 18, 2023

Codecov Report

Merging #2318 (586b136) into main (00c8a85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2318   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8519     8525    +6     
  Branches     2043     2087   +44     
=======================================
+ Hits         8299     8305    +6     
+ Misses        218      217    -1     
- Partials        2        3    +1     
Files Coverage Δ
...ilPage/CommitDetailSummary/CommitDetailSummary.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c8a85...586b136. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 586b136
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65329167e69a700008b5bb27
😎 Deploy Preview https://deploy-preview-2318--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2318 (586b136) into main (00c8a85) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2318   +/-   ##
=====================================
  Coverage   97.42   97.42           
=====================================
  Files        716     716           
  Lines       8519    8525    +6     
  Branches    2045    2093   +48     
=====================================
+ Hits        8299    8305    +6     
+ Misses       218     217    -1     
- Partials       2       3    +1     
Files Coverage Δ
...ilPage/CommitDetailSummary/CommitDetailSummary.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c8a85...586b136. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

Merging #2318 (586b136) into main (00c8a85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2318   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8519     8525    +6     
  Branches     2043     2044    +1     
=======================================
+ Hits         8299     8305    +6     
  Misses        218      218           
  Partials        2        2           
Files Coverage Δ
...ilPage/CommitDetailSummary/CommitDetailSummary.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c8a85...586b136. Read the comment docs.

Copy link
Contributor

@terry-codecov terry-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nicholas-codecov nicholas-codecov merged commit bcefa0f into main Oct 20, 2023
29 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-674-add-flags-query-param-to-commits-summary branch October 20, 2023 14:50
@sentry-io
Copy link

sentry-io bot commented Oct 25, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch graphql(shared/api/api) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flags query param to commits summary
2 participants