ref: Update TOS to work for service less users. #2321
Conversation
Add a feature flagged multi select to the CommitPageTabs component. GH codecov/engineering-team#344
* feat: add patch column to the pulls list page * uncomment development settings
…t Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633
* feat: setup pull request page to pass around selected flags in links * Feedback, fix passing links to files+folders, additional testing * fix file explorer test failing on href match due to new query param pass through * airplane commit, cant check local dev server: Resolve merge issues / tests + unify codebases missed of commitSHA and commitSha to just commitSha * Prevent multislect from collapsing + wire up PR details page to pass through flags links * Fix accidental removal of ref on usePrefetchPullFileEntry * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 --------- Co-authored-by: Adrian <[email protected]> Co-authored-by: nicholas-codecov <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
- Coverage 97.26% 97.25% -0.01%
==========================================
Files 721 721
Lines 8615 8609 -6
Branches 2124 2115 -9
==========================================
- Hits 8379 8373 -6
Misses 233 233
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
- Coverage 97.26% 97.25% -0.01%
==========================================
Files 721 721
Lines 8615 8609 -6
Branches 2124 2103 -21
==========================================
- Hits 8379 8373 -6
Misses 233 233
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2321 +/- ##
=====================================
Coverage 97.26 97.26
=====================================
Files 721 721
Lines 8615 8609 -6
Branches 2118 2103 -15
=====================================
- Hits 8379 8373 -6
+ Misses 234 233 -1
- Partials 2 3 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <TermsOfService /> | ||
| </Suspense> | ||
| ) | ||
| return <Redirect to="/terms" /> |
There was a problem hiding this comment.
I think having a dedicated route and using redirects means the original path the user was trying to access will be lost. Example:
User comes from a PR link, hasn't signed TOS, when they sign it they're sent to the /:provider/:org not the PR they clicked on.
Is this a known trade off we're making?
There was a problem hiding this comment.
I think it’s fine. we require no synced services to render this page, TOS lived under a component that used queries that serve on providers so it made sense to take it out, otherwise we would have to alter HomePageRedirect
and other components to make this happen
There was a problem hiding this comment.
Ps. Might be worth it to do the same thing for default org? sync page has it’s own dedicated route as well, I think it’s weird to jump from /terms -> /sync -> /gh But then again, default org works fine with services.
There was a problem hiding this comment.
I've to raised this to AJ. I (unfortunately) think loosing the navigation path is not good UX and that another approach might be needed here.. But I'll let him weigh the trade offs
There was a problem hiding this comment.
sure. do you mind including me in the conversation please?
There was a problem hiding this comment.
Yup for sure! I directed him to this PR actually how ever if more slacking happens we'll move to the team channel
There was a problem hiding this comment.
synced w/AJ i'll try to get it working without a new route, thought it does not effect new users but AJ believe it's good to handle too
Codecov Report
@@ Coverage Diff @@
## main #2321 +/- ##
=======================================
Coverage ? 97.41%
=======================================
Files ? 716
Lines ? 8520
Branches ? 2085
=======================================
Hits ? 8300
Misses ? 218
Partials ? 2
Continue to review full report in Codecov by Sentry.
|
| let uri = `${config.API_URL}/graphql/${provider}` | ||
|
|
||
| if (supportsServiceless && !provider) { | ||
| uri = `${config.API_URL}/graphql/` |
There was a problem hiding this comment.
Is the / needed when the original one doesn't have it?
There was a problem hiding this comment.
yah the endpoint requires/ unlike when there are providers passed
* Update with service less requests * Make sure hook supports service less * feat: Add Flag MultiSelect to CommitPageTabs (#2303) Add a feature flagged multi select to the CommitPageTabs component. GH codecov/engineering-team#344 * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 * Setup pull request page to pass around selected flags (#2282) * feat: setup pull request page to pass around selected flags in links * Feedback, fix passing links to files+folders, additional testing * fix file explorer test failing on href match due to new query param pass through * airplane commit, cant check local dev server: Resolve merge issues / tests + unify codebases missed of commitSHA and commitSha to just commitSha * Prevent multislect from collapsing + wire up PR details page to pass through flags links * Fix accidental removal of ref on usePrefetchPullFileEntry * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 --------- Co-authored-by: Adrian <[email protected]> Co-authored-by: nicholas-codecov <[email protected]> * chore: Remove segment from frontend (#2314) * Update with tests * test with support service less * adjust logic to handle original route * it's fine it works with no providers --------- Co-authored-by: nicholas-codecov <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: Terry <[email protected]>
* first pass, wheeeeeo * Sorting functionality * Update with tests * wrap up repos list: * Spelling correction (#2336) * 616 add patch setction pr page team tier (#2337) * feat: add header component for team tier customers * feat: converted Header.jsx to Header.tsx + tests * fix: add comparison schema types * fix: Filter out certain browser from sending events to Sentry (#2338) Filter out events for a given browser because they don't have all JS functions fully implemented causing issues that we cannot address. * feat: Hide Flag MultiSelect when on Team Plan on Commit Detail Page (#2327) We will need to hide the flag multi select on the commit detail page when the user is on the team plan as they are not an available feature to those users. GH codecov/engineering-team#687 * feat, ref: Disable Flag MultiSelect on Coverage Tab when on a Team Plan (#2329) Disable the flag multi-select on the coverage tab when users/orgs are on a team plan. GH codecov/engineering-team#685 * feat: Grab flags in IndirectChangesTable and pass along with request (#2335) Update indirect changes tab on the commit detail page to grab flags from the url params and pass along as query args. GH codecov/engineering-team#348 * feat: Update CommitDetailPage FilesChangedTable to pass along flags (#2334) Update the files changed tab on the commit detail page to grab flags url param and pass along as query args. GH codecov/engineering-team#347 * ref: Update TOS to work for service less users. (#2321) * Update with service less requests * Make sure hook supports service less * feat: Add Flag MultiSelect to CommitPageTabs (#2303) Add a feature flagged multi select to the CommitPageTabs component. GH codecov/engineering-team#344 * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 * Setup pull request page to pass around selected flags (#2282) * feat: setup pull request page to pass around selected flags in links * Feedback, fix passing links to files+folders, additional testing * fix file explorer test failing on href match due to new query param pass through * airplane commit, cant check local dev server: Resolve merge issues / tests + unify codebases missed of commitSHA and commitSha to just commitSha * Prevent multislect from collapsing + wire up PR details page to pass through flags links * Fix accidental removal of ref on usePrefetchPullFileEntry * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 --------- Co-authored-by: Adrian <[email protected]> Co-authored-by: nicholas-codecov <[email protected]> * chore: Remove segment from frontend (#2314) * Update with tests * test with support service less * adjust logic to handle original route * it's fine it works with no providers --------- Co-authored-by: nicholas-codecov <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: Terry <[email protected]> * restructure folders anticipating second header component for team tier (#2340) * feat: add hook for commit detail page team tier (#2341) * build: Update PostCSS (#2346) Update PostCSS dependency. * Migrate TextInput to TypeScript (#2342) * Migrate textinput to TS * Add story * formatting * organize imports * Connect flag selector to flags filter on PR details page (#2343) * feat: Update impacted files resolver for use pull, connect the flag selector to the api. * update missing logic as requested + unknown flags message to be aligned with repo overview design * Noticed the changing the pull query broke impacted files while smoke testing, dupicated the same compatibility work for the new resolver. * Refactor to use a impacted files enum as requested. * fix: Attempting to fix CommitDetailPage and RepoPage Tests (#2350) Addressing flaky tests in CommitDetailPage and RepoPage. * Add patch section commit detail page team tier (#2344) * restructure folders anticipating second header component for team tier * feat: add patch coverage section to commit detail page for team tier customer * fix: rename HeaderDefault to HeaderTeam for team file * Convert Sparkline to typescript (#2347) * Convert sparkline to typescript * Consistent type defs * better variable names * use enum * quick fixes * Update use memo * Update tests with getSortingOption * pull out the function of the test block --------- Co-authored-by: Joe Becher <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: nicholas-codecov <[email protected]> Co-authored-by: Terry <[email protected]> Co-authored-by: Rohit Vinnakota <[email protected]>
Description
To allow users that haven't yet synced a provider to accept tos, we had to refactor the page to fire the updated serviceless mutation/handle internal user.
Notable Changes
suppportsServiceless./termsif terms page meant to be displayed.Screenshots
Screen.Recording.2023-10-18.at.4.38.27.PM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.