Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swap from useLocationParams to useLocation in RawFileviewer #2325

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Super small PR to quickly swap out the way that RawFileviewer fetches the flags from the URL to use useLocation because useLocationParams should probably be reserved for use when also updating URL params.

Notable Changes

  • Switch to using useLocation instead of useLocationParams in RawFileviewer to fetch flags.

@nicholas-codecov nicholas-codecov changed the title fix: Swap from useLocationParams to useLocation fix: Swap from useLocationParams to useLocation in RawFileviewer Oct 19, 2023
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit a3366cb
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653293d957364d0008c9aa28
😎 Deploy Preview https://deploy-preview-2325--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

Merging #2325 (a3366cb) into main (bcefa0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8525     8526    +1     
  Branches     2075     2094   +19     
=======================================
+ Hits         8305     8306    +1     
  Misses        217      217           
  Partials        3        3           
Files Coverage Δ
src/shared/RawFileviewer/RawFileviewer.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcefa0f...a3366cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2325 (a3366cb) into main (bcefa0f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2325   +/-   ##
=====================================
  Coverage   97.42   97.42           
=====================================
  Files        716     716           
  Lines       8525    8526    +1     
  Branches    2042    2088   +46     
=====================================
+ Hits        8305    8306    +1     
  Misses       218     218           
  Partials       2       2           
Files Coverage Δ
src/shared/RawFileviewer/RawFileviewer.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcefa0f...a3366cb. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 19, 2023

Codecov Report

Merging #2325 (a3366cb) into main (bcefa0f) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8525     8526    +1     
  Branches     2087     2076   -11     
=======================================
+ Hits         8305     8306    +1     
  Misses        217      217           
  Partials        3        3           
Files Coverage Δ
src/shared/RawFileviewer/RawFileviewer.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcefa0f...a3366cb. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 19, 2023

Codecov Report

Merging #2325 (a3366cb) into main (bcefa0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         716      716           
  Lines        8525     8526    +1     
  Branches     2087     2043   -44     
=======================================
+ Hits         8305     8306    +1     
  Misses        218      218           
  Partials        2        2           
Files Coverage Δ
src/shared/RawFileviewer/RawFileviewer.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcefa0f...a3366cb. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 9fcb8c1 into main Oct 20, 2023
32 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-switch-raw-file-viewer-flag-grabbing-to-use-location branch October 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants