-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Swap from useLocationParams to useLocation in RawFileviewer #2325
fix: Swap from useLocationParams to useLocation in RawFileviewer #2325
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 716 716
Lines 8525 8526 +1
Branches 2075 2094 +19
=======================================
+ Hits 8305 8306 +1
Misses 217 217
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
=====================================
Coverage 97.42 97.42
=====================================
Files 716 716
Lines 8525 8526 +1
Branches 2042 2088 +46
=====================================
+ Hits 8305 8306 +1
Misses 218 218
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 716 716
Lines 8525 8526 +1
Branches 2087 2076 -11
=======================================
+ Hits 8305 8306 +1
Misses 217 217
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 716 716
Lines 8525 8526 +1
Branches 2087 2043 -44
=======================================
+ Hits 8305 8306 +1
Misses 218 218
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Description
Super small PR to quickly swap out the way that
RawFileviewer
fetches the flags from the URL to useuseLocation
becauseuseLocationParams
should probably be reserved for use when also updating URL params.Notable Changes
useLocation
instead ofuseLocationParams
inRawFileviewer
to fetch flags.