Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Commit Summary from Commit Detail Page on Team Plan #2352

Merged

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 27, 2023

Description

This PR hides the commit summary on the commit detail page when the owner is on a team plan as well as the repo being private, if the repo is public then it will still show the commit summary.

Closes codecov/engineering-team#618

Notable Changes

  • Update the CommitDetailPage to conditionally render the CommitDetailSummary based off of repo visibility and tier value.
  • Update tests to check new cases.

Screenshots

Public Repo:

Screenshot 2023-10-27 at 7 45 32 AM

Private Repo:

Screenshot 2023-10-27 at 7 47 44 AM

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 2e1b9c3
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6542923a03f94900086ded79
😎 Deploy Preview https://deploy-preview-2352--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Oct 27, 2023

Codecov Report

Merging #2352 (2e1b9c3) into main (72cc111) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2352   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         727      727           
  Lines        8710     8715    +5     
  Branches     2107     2161   +54     
=======================================
+ Hits         8462     8467    +5     
+ Misses        246      245    -1     
- Partials        2        3    +1     
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc111...2e1b9c3. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@72cc111). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head e34c23a differs from pull request most recent head 2e1b9c3. Consider uploading reports for the commit 2e1b9c3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2352   +/-   ##
=======================================
  Coverage        ?   97.15%           
=======================================
  Files           ?      725           
  Lines           ?     8686           
  Branches        ?     2104           
=======================================
  Hits            ?     8439           
  Misses          ?      245           
  Partials        ?        2           
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc111...2e1b9c3. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@72cc111). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head e34c23a differs from pull request most recent head 2e1b9c3. Consider uploading reports for the commit 2e1b9c3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2352   +/-   ##
=======================================
  Coverage        ?   97.15%           
=======================================
  Files           ?      725           
  Lines           ?     8686           
  Branches        ?     2147           
=======================================
  Hits            ?     8439           
  Misses          ?      245           
  Partials        ?        2           
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc111...2e1b9c3. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2352 (2e1b9c3) into main (72cc111) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2352   +/-   ##
=====================================
  Coverage   97.15   97.15           
=====================================
  Files        727     727           
  Lines       8710    8715    +5     
  Branches    2152    2155    +3     
=====================================
+ Hits        8462    8467    +5     
  Misses       246     246           
  Partials       2       2           
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc111...2e1b9c3. Read the comment docs.

Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JC what's the reasoning behind only hiding private repo summaries for this tier?

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-618-remove-commit-summary-component-on-team-plan branch from e34c23a to 2e1b9c3 Compare November 1, 2023 18:00
@nicholas-codecov nicholas-codecov merged commit e8473e3 into main Nov 1, 2023
28 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-618-remove-commit-summary-component-on-team-plan branch November 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] - Commit Detail Page: Remove Summary Section for Team Tier
3 participants