-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Commit Summary from Commit Detail Page on Team Plan #2352
feat: Remove Commit Summary from Commit Detail Page on Team Plan #2352
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2352 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 727 727
Lines 8710 8715 +5
Branches 2107 2161 +54
=======================================
+ Hits 8462 8467 +5
+ Misses 246 245 -1
- Partials 2 3 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
=======================================
Coverage ? 97.15%
=======================================
Files ? 725
Lines ? 8686
Branches ? 2104
=======================================
Hits ? 8439
Misses ? 245
Partials ? 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2352 +/- ##
=======================================
Coverage ? 97.15%
=======================================
Files ? 725
Lines ? 8686
Branches ? 2147
=======================================
Hits ? 8439
Misses ? 245
Partials ? 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2352 +/- ##
=====================================
Coverage 97.15 97.15
=====================================
Files 727 727
Lines 8710 8715 +5
Branches 2152 2155 +3
=====================================
+ Hits 8462 8467 +5
Misses 246 246
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JC what's the reasoning behind only hiding private repo summaries for this tier?
e34c23a
to
2e1b9c3
Compare
Description
This PR hides the commit summary on the commit detail page when the owner is on a team plan as well as the repo being private, if the repo is public then it will still show the commit summary.
Closes codecov/engineering-team#618
Notable Changes
CommitDetailPage
to conditionally render theCommitDetailSummary
based off of repo visibility and tier value.Screenshots
Public Repo:
Private Repo: