feat: change planName to value for planData hook #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fullstack convention
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2359 +/- ##
===========================================
+ Coverage 35.79% 97.15% +61.35%
===========================================
Files 700 725 +25
Lines 8623 8681 +58
Branches 2099 2132 +33
===========================================
+ Hits 3087 8434 +5347
+ Misses 5438 244 -5194
+ Partials 98 3 -95
... and 427 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
===========================================
+ Coverage 35.79% 97.15% +61.35%
===========================================
Files 700 725 +25
Lines 8623 8681 +58
Branches 2150 2099 -51
===========================================
+ Hits 3087 8434 +5347
+ Misses 5433 245 -5188
+ Partials 103 2 -101
... and 427 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2359 +/- ##
===========================================
+ Coverage 35.79% 97.15% +61.35%
===========================================
Files 700 725 +25
Lines 8623 8681 +58
Branches 2144 2144
===========================================
+ Hits 3087 8434 +5347
+ Misses 5433 244 -5189
+ Partials 103 3 -100
... and 427 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2359 +/- ##
========================================
+ Coverage 35.80 97.15 +61.35
========================================
Files 700 725 +25
Lines 8623 8681 +58
Branches 2144 2150 +6
========================================
+ Hits 3087 8434 +5347
+ Misses 5438 244 -5194
+ Partials 98 3 -95
... and 427 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're changing the
planNameresolver value for plan data tovalue. Historically, we've usedvalue, and although we ultimately want to useplanName, maintaining both keys/utils/proptypes/revolving logic with different key names can be hard to follow, specially with those files not using TS atm.Notable Changes
usePlanDatahook to usevalueoverplanNameLink to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.