feat: refactor and rename paidplancard #2367
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const scheduledPhase = accountDetails?.scheduleDetail?.scheduledPhase | ||
| const plan = planData?.plan | ||
| const marketingName = plan?.marketingName | ||
| const benefits = plan?.benefits | ||
| const value = plan?.value | ||
| const baseUnitPrice = plan?.baseUnitPrice | ||
| const seats = plan?.planUserCount |
There was a problem hiding this comment.
Are you able to provide any default values here if these values are possibly null?
There was a problem hiding this comment.
So all of these can't be nullable as per our backend/zod schema, so we should be fine here.
But otherwise, for a scenario that applies, what default value would work here? It almost feels like if we didn't have all of these that we shouldn't show the card, or have designs reflect that state (but to be clear, they're non-nullable here)
There was a problem hiding this comment.
Ah I see, the optional chaining made me think they were possibly nullable
|
Ignore me about the test coverage seemed like a runner failed 😢 should be able to restart that single runner without causing a lot more reports to be uploaded 🤞 |
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 97.05% 97.06%
=======================================
Files 732 732
Lines 8806 8814 +8
Branches 2125 2125
=======================================
+ Hits 8547 8555 +8
Misses 256 256
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
=====================================
Coverage 97.06 97.06
=====================================
Files 732 732
Lines 8806 8814 +8
Branches 2169 2174 +5
=====================================
+ Hits 8547 8555 +8
Misses 255 255
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Description
I'm adding some logic to cleanup the
ProPlanCard, renamed toPaidPlanCard. I initially thought it was going to be more logic but ended up being just a minor refactor after all, this one should be fairly easy.Notable Changes
ProPlanCardtoPaidPlanCardand everywhere it used itScreenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.