Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics changes tab for team plan #2368

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

adrian-codecov
Copy link
Contributor

Description

This a revert from this change, #2310, that I couldn't manually revert via GH

Notable Changes

  • Removed logic that prevents access to analytics page if you are part of the team tier

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit a8a7816
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6542a05c9e3a7e0009104f82
😎 Deploy Preview https://deploy-preview-2368--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 1, 2023

Codecov Report

Merging #2368 (a8a7816) into main (7cf5a8d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.01%     
==========================================
  Files         732      732              
  Lines        8834     8806      -28     
  Branches     2172     2174       +2     
==========================================
- Hits         8575     8547      -28     
  Misses        255      255              
  Partials        4        4              
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf5a8d...a8a7816. Read the comment docs.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2368 (a8a7816) into main (7cf5a8d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2368     +/-   ##
=======================================
- Coverage   97.07   97.06   -0.01     
=======================================
  Files        732     732             
  Lines       8834    8806     -28     
  Branches    2141    2125     -16     
=======================================
- Hits        8575    8547     -28     
  Misses       256     256             
  Partials       3       3             
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <ø> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf5a8d...a8a7816. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 🚀

@adrian-codecov adrian-codecov merged commit 18c50f3 into main Nov 1, 2023
25 checks passed
@adrian-codecov adrian-codecov deleted the 725-revert-analytic-team-tier-changes branch November 1, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants