feat: Create a New Table for the Commits Tab on the Pull Request Page for the Team Plan #2373

nicholas-codecov · 2023-11-02T16:41:05Z

Description

This PR creates a new table for the commits tab on the pull request page for users on the team plan when viewing a private repo.

Closes codecov/engineering-team#623

Notable Changes

Create new CommitsTableTeam component
Create new createCommitsTableTeamData to create table data
Update CommitsTab to conditionally render differing tables
Update tests

Screenshots

netlify · 2023-11-02T16:44:15Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`ca75397`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/6548e837b7ad000008bce0ac
😎 Deploy Preview	https://deploy-preview-2373--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-staging · 2023-11-02T16:45:24Z

Codecov Report

Merging #2373 (ca75397) into main (f54c1a7) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
- Coverage   96.27%   96.08%   -0.19%     
==========================================
  Files         736      738       +2     
  Lines        8970     9023      +53     
  Branches     2186     2233      +47     
==========================================
+ Hits         8636     8670      +34     
- Misses        318      335      +17     
- Partials       16       18       +2

Files	Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
.../subroute/CommitsTab/CommitsTable/CommitsTable.jsx	`100.00% <ø> (ø)`
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx	`100.00% <100.00%> (ø)`
...ab/CommitsTableTeam/createCommitsTableTeamData.tsx	`100.00% <100.00%> (ø)`
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.jsx	`100.00% <ø> (ø)`
...estPage/subroute/CommitsTab/shared/Title/Title.jsx	`100.00% <ø> (ø)`

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c1a7...ca75397. Read the comment docs.

codecov-qa · 2023-11-02T16:45:29Z

Codecov Report

Merging #2373 (ca75397) into main (f54c1a7) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
- Coverage   96.27%   96.08%   -0.19%     
==========================================
  Files         736      738       +2     
  Lines        8970     9023      +53     
  Branches     2219     2251      +32     
==========================================
+ Hits         8636     8670      +34     
- Misses        317      335      +18     
- Partials       17       18       +1

Files	Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
.../subroute/CommitsTab/CommitsTable/CommitsTable.jsx	`100.00% <ø> (ø)`
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx	`100.00% <100.00%> (ø)`
...ab/CommitsTableTeam/createCommitsTableTeamData.tsx	`100.00% <100.00%> (ø)`
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.jsx	`100.00% <ø> (ø)`
...estPage/subroute/CommitsTab/shared/Title/Title.jsx	`100.00% <ø> (ø)`

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c1a7...ca75397. Read the comment docs.

codecov · 2023-11-02T16:45:37Z

Codecov Report

Merging #2373 (ca75397) into main (f54c1a7) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            main   #2373     +/-   ##
=======================================
- Coverage   96.28   96.09   -0.19     
=======================================
  Files        736     738      +2     
  Lines       8970    9023     +53     
  Branches    2232    2202     -30     
=======================================
+ Hits        8636    8670     +34     
- Misses       318     337     +19     
  Partials      16      16

Files	Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
.../subroute/CommitsTab/CommitsTable/CommitsTable.jsx	`100.00% <ø> (ø)`
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx	`100.00% <100.00%> (ø)`
...ab/CommitsTableTeam/createCommitsTableTeamData.tsx	`100.00% <100.00%> (ø)`
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.jsx	`100.00% <ø> (ø)`
...estPage/subroute/CommitsTab/shared/Title/Title.jsx	`100.00% <ø> (ø)`

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c1a7...ca75397. Read the comment docs.

adrian-codecov

Lgtm!

adrian-codecov · 2023-11-03T18:08:24Z

src/pages/PullRequestPage/subroute/CommitsTab/CommitsTab.jsx

@@ -11,9 +15,16 @@ const Loader = () => (
 )

 function CommitsTab() {
+  const { provider, owner } = useParams()


I've really come to like these sort of "intermediate" files, where their sole purpose is to direct you to a different "version" of what you want to see. I suppose we didn't have the need for this before, but I find this so readable and easy to follow, pat on our backs

One other nice thing about this, is that with this pattern we're only loading the JS for the path we're taking thanks Suspense!

…-on-pull-request-page

nicholas-codecov added 5 commits November 2, 2023 13:35

move CIStatus and Title to a shared dir

c2e8009

update imports for CommitsTable to new shared dir

1fcf17a

create new function to format data correctly for new table

eb53fd5

create new table for team plan on pulls subroute

8a26a7a

update CommitsTab to handle team plan on private repos

41ee0de

adrian-codecov approved these changes Nov 3, 2023

View reviewed changes

nicholas-codecov added 2 commits November 6, 2023 07:29

Merge branch 'main' into gh-eng-623-create-new-table-for-commits-list…

4e52f12

…-on-pull-request-page

Merge branch 'main' into gh-eng-623-create-new-table-for-commits-list…

ca75397

…-on-pull-request-page

nicholas-codecov merged commit 132153c into main Nov 6, 2023
27 of 30 checks passed

nicholas-codecov deleted the gh-eng-623-create-new-table-for-commits-list-on-pull-request-page branch November 6, 2023 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Create a New Table for the Commits Tab on the Pull Request Page for the Team Plan #2373

feat: Create a New Table for the Commits Tab on the Pull Request Page for the Team Plan #2373

nicholas-codecov commented Nov 2, 2023

netlify bot commented Nov 2, 2023 •

edited

Loading

codecov-staging bot commented Nov 2, 2023 •

edited

Loading

codecov-qa bot commented Nov 2, 2023 •

edited

Loading

codecov bot commented Nov 2, 2023 •

edited

Loading

adrian-codecov left a comment

adrian-codecov Nov 3, 2023

nicholas-codecov Nov 6, 2023

feat: Create a New Table for the Commits Tab on the Pull Request Page for the Team Plan #2373

feat: Create a New Table for the Commits Tab on the Pull Request Page for the Team Plan #2373

Conversation

nicholas-codecov commented Nov 2, 2023

Description

Notable Changes

Screenshots

netlify bot commented Nov 2, 2023 • edited Loading

✅ Deploy Preview for gazebo-staging ready!

codecov-staging bot commented Nov 2, 2023 • edited Loading

Codecov Report

codecov-qa bot commented Nov 2, 2023 • edited Loading

Codecov Report

codecov bot commented Nov 2, 2023 • edited Loading

Codecov Report

adrian-codecov left a comment

Choose a reason for hiding this comment

adrian-codecov Nov 3, 2023

Choose a reason for hiding this comment

nicholas-codecov Nov 6, 2023

Choose a reason for hiding this comment

netlify bot commented Nov 2, 2023 •

edited

Loading

codecov-staging bot commented Nov 2, 2023 •

edited

Loading

codecov-qa bot commented Nov 2, 2023 •

edited

Loading

codecov bot commented Nov 2, 2023 •

edited

Loading