Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update Zod Schemas with Updated Resolver Types #2387

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates a handful of Zod schemas to match the updated types in the GraphQL schema in the API mainly focused on removing a handful of .nullable()'s that are no longer nullable.

Closes codecov/engineering-team#704

Notable Changes

  • Updated lots of zod schemas
  • Updated a lot of tests

@codecov-staging
Copy link

codecov-staging bot commented Nov 7, 2023

Codecov Report

Merging #2387 (f961a80) into main (4c337d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         750      750           
  Lines        9411     9415    +4     
  Branches     2369     2365    -4     
=======================================
+ Hits         9052     9056    +4     
  Misses        341      341           
  Partials       18       18           
Files Coverage Δ
...Header/HeaderDefault/hooks/useCommitHeaderData.tsx 100.00% <ø> (ø)
...eader/HeaderTeam/hooks/useCommitHeaderDataTeam.tsx 100.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 100.00% <ø> (ø)
...age/Header/HeaderDefault/hooks/usePullHeadData.tsx 100.00% <ø> (ø)
...ge/Header/HeaderTeam/hooks/usePullHeadDataTeam.tsx 100.00% <ø> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
src/services/branches/useBranch.tsx 100.00% <ø> (ø)
src/services/branches/useBranches.tsx 100.00% <ø> (ø)
src/services/commit/useCommit.tsx 98.00% <ø> (ø)
src/services/commit/useCommitTeam.tsx 100.00% <ø> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c337d9...f961a80. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 7, 2023

Codecov Report

Merging #2387 (f961a80) into main (4c337d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         750      750           
  Lines        9411     9415    +4     
  Branches     2351     2365   +14     
=======================================
+ Hits         9052     9056    +4     
  Misses        341      341           
  Partials       18       18           
Files Coverage Δ
...Header/HeaderDefault/hooks/useCommitHeaderData.tsx 100.00% <ø> (ø)
...eader/HeaderTeam/hooks/useCommitHeaderDataTeam.tsx 100.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 100.00% <ø> (ø)
...age/Header/HeaderDefault/hooks/usePullHeadData.tsx 100.00% <ø> (ø)
...ge/Header/HeaderTeam/hooks/usePullHeadDataTeam.tsx 100.00% <ø> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
src/services/branches/useBranch.tsx 100.00% <ø> (ø)
src/services/branches/useBranches.tsx 100.00% <ø> (ø)
src/services/commit/useCommit.tsx 98.00% <ø> (ø)
src/services/commit/useCommitTeam.tsx 100.00% <ø> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c337d9...f961a80. Read the comment docs.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2387 (f961a80) into main (4c337d9) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2387   +/-   ##
=====================================
  Coverage   96.19   96.19           
=====================================
  Files        750     750           
  Lines       9411    9415    +4     
  Branches    2364    2352   -12     
=====================================
+ Hits        9052    9056    +4     
+ Misses       343     341    -2     
- Partials      16      18    +2     
Files Coverage Δ
...Header/HeaderDefault/hooks/useCommitHeaderData.tsx 100.00% <ø> (ø)
...eader/HeaderTeam/hooks/useCommitHeaderDataTeam.tsx 100.00% <ø> (ø)
...ges/DefaultOrgSelector/hooks/useMyOrganizations.ts 100.00% <ø> (ø)
...age/Header/HeaderDefault/hooks/usePullHeadData.tsx 100.00% <ø> (ø)
...ge/Header/HeaderTeam/hooks/usePullHeadDataTeam.tsx 100.00% <ø> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
src/services/branches/useBranch.tsx 100.00% <ø> (ø)
src/services/branches/useBranches.tsx 100.00% <ø> (ø)
src/services/commit/useCommit.tsx 98.00% <ø> (ø)
src/services/commit/useCommitTeam.tsx 100.00% <ø> (ø)
... and 4 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c337d9...f961a80. Read the comment docs.

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit f961a80
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/655383608280dd0008bb7392
😎 Deploy Preview https://deploy-preview-2387--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/DefaultOrgSelector/hooks/useMyOrganizations.ts Outdated Show resolved Hide resolved
src/services/commits/useCommitsTeam.tsx Outdated Show resolved Hide resolved
src/services/pulls/usePulls.tsx Outdated Show resolved Hide resolved
src/services/pulls/usePullsTeam.tsx Outdated Show resolved Hide resolved
src/services/user/useInternalUser.ts Outdated Show resolved Hide resolved
src/services/user/useInternalUser.ts Outdated Show resolved Hide resolved
src/services/user/useInternalUser.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicholas-codecov nicholas-codecov merged commit eab2e85 into main Nov 14, 2023
30 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-704-update-zod-schemas-with-updated-resolver-types branch November 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Update Zod Schemas with Updated Resolver Types
2 participants