-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Update Zod Schemas with Updated Resolver Types #2387
ref: Update Zod Schemas with Updated Resolver Types #2387
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2387 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9411 9415 +4
Branches 2369 2365 -4
=======================================
+ Hits 9052 9056 +4
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9411 9415 +4
Branches 2351 2365 +14
=======================================
+ Hits 9052 9056 +4
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
=====================================
Coverage 96.19 96.19
=====================================
Files 750 750
Lines 9411 9415 +4
Branches 2364 2352 -12
=====================================
+ Hits 9052 9056 +4
+ Misses 343 341 -2
- Partials 16 18 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/pages/CommitDetailPage/CommitDetailPageContent/CommitDetailPageContent.spec.jsx
Show resolved
Hide resolved
src/pages/CommitDetailPage/Header/HeaderDefault/hooks/useCommitHeaderData.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR updates a handful of Zod schemas to match the updated types in the GraphQL schema in the API mainly focused on removing a handful of
.nullable()
's that are no longer nullable.Closes codecov/engineering-team#704
Notable Changes