fix: Remove default org feature flag and adjust useUserAccessGate
#2388
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
- Coverage 96.22% 96.22% -0.01%
==========================================
Files 750 750
Lines 9407 9400 -7
Branches 2360 2359 -1
==========================================
- Hits 9052 9045 -7
Misses 338 338
Partials 17 17
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
=======================================
- Coverage 96.23 96.22 -0.01
=======================================
Files 750 750
Lines 9407 9400 -7
Branches 2347 2359 +12
=======================================
- Hits 9052 9045 -7
Misses 338 338
Partials 17 17
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
- Coverage 96.22% 96.22% -0.01%
==========================================
Files 750 750
Lines 9407 9400 -7
Branches 2314 2354 +40
==========================================
- Hits 9052 9045 -7
+ Misses 340 338 -2
- Partials 15 17 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RulaKhaled
changed the title
useUserAccessGateuseUserAccessGate
Description
While removing default org feature flag i noticed that we are handling missing user weirdly, in a way that if the request fails, we still update the fields e.g showDefaultOrg which was causing some weird behaviors in use user access gate hook.
Notable Changes
-> Fix missing user and handle update values if user data exists
-> Decouple internal user and user
-> Remove default org flag
-> Update tests
Screenshots
nothing visual changed
closes: codecov/engineering-team#483
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.