Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add percentage next to patch column title for team plan tables #2390

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description

Closes codecov/engineering-team#782. Pretty straightforward.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title change table header Add percentage next to patch column title Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 421804e
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/654c2c72c745dc00087ebc39
😎 Deploy Preview https://deploy-preview-2390--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Codecov Report

Merging #2390 (421804e) into main (23d501c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2390   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9325     9325           
  Branches     2332     2332           
=======================================
  Hits         8966     8966           
- Misses        341      343    +2     
+ Partials       18       16    -2     
Files Coverage Δ
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d501c...421804e. Read the comment docs.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2390 (421804e) into main (23d501c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2390   +/-   ##
=====================================
  Coverage   96.15   96.15           
=====================================
  Files        748     748           
  Lines       9325    9325           
  Branches    2286    2286           
=====================================
  Hits        8966    8966           
  Misses       343     343           
  Partials      16      16           
Files Coverage Δ
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d501c...421804e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 9, 2023

Codecov Report

Merging #2390 (421804e) into main (23d501c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2390   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9325     9325           
  Branches     2332     2288   -44     
=======================================
  Hits         8966     8966           
- Misses        341      343    +2     
+ Partials       18       16    -2     
Files Coverage Δ
...e/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d501c...421804e. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Add percentage next to patch column title Add percentage next to patch column title for team plan tables Nov 9, 2023
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Add percentage next to patch column title for team plan tables fix: Add percentage next to patch column title for team plan tables Nov 9, 2023
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review November 9, 2023 15:08
@terry-codecov terry-codecov merged commit bc1c05a into main Nov 9, 2023
30 checks passed
@terry-codecov terry-codecov deleted the rvinnakota/change-team-table-header branch November 9, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Add percentage next to patch column title (UI tweak)
2 participants