Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show Branch Icon in Branch Dropdown for Team Plan #2392

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR enables devs to pass along an icon that lives next to the select text, as well as updating the team plan version of the coverage tab summary to pass along a branch icon. This change in plan was confirmed with design.

Closes codecov/engineering-team#780

Notable Changes

  • Update Select to support passing along a button icon prop
  • Update SummaryTeamPlan to pass along the branch icon
  • Update tests

Screenshots

Screenshot 2023-11-09 at 9 12 01 AM

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 701fa82
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/654cfe1ac8a2930008c3dabe
😎 Deploy Preview https://deploy-preview-2392--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 9, 2023

Codecov Report

Merging #2392 (701fa82) into main (56c0992) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9326     9326           
  Branches     2332     2332           
=======================================
  Hits         8967     8967           
- Misses        341      343    +2     
+ Partials       18       16    -2     
Files Coverage Δ
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <ø> (ø)
src/ui/Select/Select.jsx 96.55% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c0992...701fa82. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 9, 2023

Codecov Report

Merging #2392 (701fa82) into main (56c0992) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9326     9326           
  Branches     2286     2337   +51     
=======================================
  Hits         8967     8967           
+ Misses        343      341    -2     
- Partials       16       18    +2     
Files Coverage Δ
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <ø> (ø)
src/ui/Select/Select.jsx 96.55% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c0992...701fa82. Read the comment docs.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2392 (701fa82) into main (56c0992) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2392   +/-   ##
=====================================
  Coverage   96.15   96.15           
=====================================
  Files        748     748           
  Lines       9326    9326           
  Branches    2332    2332           
=====================================
  Hits        8967    8967           
+ Misses       343     341    -2     
- Partials      16      18    +2     
Files Coverage Δ
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <ø> (ø)
src/ui/Select/Select.jsx 96.55% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c0992...701fa82. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 24acb04 into main Nov 9, 2023
30 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-780-fix-hidden-branch-selector-title-on-coverage-tab branch November 9, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Add branch selector title for repo page coverage tab (UI tweak)
2 participants