-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show Branch Icon in Branch Dropdown for Team Plan #2392
fix: Show Branch Icon in Branch Dropdown for Team Plan #2392
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 748 748
Lines 9326 9326
Branches 2332 2332
=======================================
Hits 8967 8967
- Misses 341 343 +2
+ Partials 18 16 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 748 748
Lines 9326 9326
Branches 2286 2337 +51
=======================================
Hits 8967 8967
+ Misses 343 341 -2
- Partials 16 18 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
=====================================
Coverage 96.15 96.15
=====================================
Files 748 748
Lines 9326 9326
Branches 2332 2332
=====================================
Hits 8967 8967
+ Misses 343 341 -2
- Partials 16 18 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
This PR enables devs to pass along an icon that lives next to the select text, as well as updating the team plan version of the coverage tab summary to pass along a branch icon. This change in plan was confirmed with design.
Closes codecov/engineering-team#780
Notable Changes
Select
to support passing along a button icon propSummaryTeamPlan
to pass along the branch iconScreenshots