Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align items in flags summary page #2394

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Nov 9, 2023

Description

This closes codecov/engineering-team#240. It keeps the sparkline and trend information consistently aligned(see screenshots).

Screenshots

Before
Screenshot 2023-11-09 at 3 11 59 PM

After
Screenshot 2023-11-14 at 12 04 15 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit e9c8623
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6553ad1747136600089c1e04
😎 Deploy Preview https://deploy-preview-2394--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 9, 2023

Codecov Report

Merging #2394 (e9c8623) into main (eab2e85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files         750      750              
  Lines        9415     9417       +2     
  Branches     2321     2367      +46     
==========================================
+ Hits         9056     9059       +3     
+ Misses        343      342       -1     
  Partials       16       16              
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <100.00%> (ø)
...ubroute/FlagsTable/TableEntries/TableSparkline.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab2e85...e9c8623. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 9, 2023

Codecov Report

Merging #2394 (e9c8623) into main (eab2e85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files         750      750              
  Lines        9415     9417       +2     
  Branches     2365     2372       +7     
==========================================
+ Hits         9056     9059       +3     
+ Misses        341      340       -1     
  Partials       18       18              
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <100.00%> (ø)
...ubroute/FlagsTable/TableEntries/TableSparkline.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab2e85...e9c8623. Read the comment docs.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2394 (e9c8623) into main (eab2e85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2394     +/-   ##
=======================================
+ Coverage   96.19   96.20   +0.01     
=======================================
  Files        750     750             
  Lines       9415    9417      +2     
  Branches    2370    2367      -3     
=======================================
+ Hits        9056    9059      +3     
- Misses       341     342      +1     
+ Partials      18      16      -2     
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <100.00%> (ø)
...ubroute/FlagsTable/TableEntries/TableSparkline.jsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab2e85...e9c8623. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Rvinnakota/align flags table Align items in flags summary page Nov 9, 2023
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review November 9, 2023 20:23
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 9b40b19 into main Nov 14, 2023
30 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/align-flags-table branch November 14, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align items on flags summary page
2 participants