-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Place the new multi selector for components in file explorer #2463
[feat] Place the new multi selector for components in file explorer #2463
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2463 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 777 777
Lines 9993 9993
Branches 2503 2549 +46
=======================================
Hits 9807 9807
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2463 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 777 777
Lines 9993 9993
Branches 2503 2505 +2
=======================================
Hits 9807 9807
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2463 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 777 777
Lines 9993 9993
Branches 2554 2549 -5
=======================================
Hits 9807 9807
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
Adds the components multi select to the file explorer in the Coverage tab. This closes codecov/engineering-team#829.
This PR also moves
ComponentsSelectCommit
to its own ui folder for shared access across multiple components.Link to Sample Entry
Screen.Recording.2023-12-18.at.11.50.23.AM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.