-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Have upgrade to team plan links include URL search param #2470
feat: Have upgrade to team plan links include URL search param #2470
Conversation
…n plan params is in url
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 777 778 +1
Lines 10002 10026 +24
Branches 2541 2558 +17
=======================================
+ Hits 9816 9840 +24
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 777 778 +1
Lines 10002 10026 +24
Branches 2560 2563 +3
=======================================
+ Hits 9816 9840 +24
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 777 778 +1
Lines 10002 10026 +24
Branches 2555 2558 +3
=======================================
+ Hits 9816 9840 +24
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Pulled branch locally to test it so lgtm!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
========================================
+ Coverage 83.79 98.14 +14.35
========================================
Files 773 778 +5
Lines 9989 10026 +37
Branches 2560 2514 -46
========================================
+ Hits 8370 9840 +1470
+ Misses 1581 184 -1397
+ Partials 38 2 -36
... and 110 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Description
This PR updates a couple different pieces regarding the team plan, by adding in a URL search param when linking to the upgrade page so that the page will default to showing the team plan.
Closes: codecov/engineering-team#706
Notable Changes
useNavLinks -> upgradeOrgPlan
to support query params being appended to URLusePlanParams
hook to grabplan
search param from the URL?plan=team
to upgrade linkPlanTypeOptions
andUpgradePlanPage
to grab plan param and set value to team plan if they have access to the team plan.