Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Indirect changes table refactor #2552

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

Using the new ui/table for commit details indirect changes

Screenshots

Screenshot 2024-01-30 at 2 43 03 PM

closes: codecov/engineering-team#586

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2552   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         813      813           
  Lines       10641    10653   +12     
  Branches     2719     2677   -42     
=======================================
+ Hits        10466    10478   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde5079...458c148. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fde5079) 98.35% compared to head (458c148) 98.35%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2552   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         813      813           
  Lines       10641    10653   +12     
  Branches     2666     2677   +11     
=======================================
+ Hits        10466    10478   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde5079...458c148. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 30, 2024

Codecov Report

Merging #2552 (458c148) into main (fde5079) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2552   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         813      813           
  Lines       10641    10653   +12     
  Branches     2668     2675    +7     
=======================================
+ Hits        10466    10478   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde5079...458c148. Read the comment docs.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fde5079) 98.36% compared to head (458c148) 98.36%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2552   +/-   ##
=====================================
  Coverage   98.36   98.36           
=====================================
  Files        813     813           
  Lines      10641   10653   +12     
  Branches    2666    2675    +9     
=====================================
+ Hits       10466   10478   +12     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde5079...458c148. Read the comment docs.

@RulaKhaled RulaKhaled marked this pull request as draft January 30, 2024 16:29
@RulaKhaled RulaKhaled marked this pull request as ready for review February 1, 2024 14:48
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 458c148
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65c225589a5c2c0008410bb1
😎 Deploy Preview https://deploy-preview-2552--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2552.codecov.dev for your PR preview. Expires after 1 month automatically.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RulaKhaled RulaKhaled merged commit 7aed025 into main Feb 6, 2024
60 checks passed
@RulaKhaled RulaKhaled deleted the indirect-changes-table-refactor branch February 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndirectCoverageChangesTable Commit Detail Page
3 participants