-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Indirect changes table refactor #2552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2552 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10641 10653 +12
Branches 2719 2677 -42
=======================================
+ Hits 10466 10478 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10641 10653 +12
Branches 2666 2677 +11
=======================================
+ Hits 10466 10478 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2552 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10641 10653 +12
Branches 2668 2675 +7
=======================================
+ Hits 10466 10478 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
=====================================
Coverage 98.36 98.36
=====================================
Files 813 813
Lines 10641 10653 +12
Branches 2666 2675 +9
=====================================
+ Hits 10466 10478 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit https://preview-pr-2552.codecov.dev for your PR preview. Expires after 1 month automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Using the new ui/table for commit details indirect changes
Screenshots
closes: codecov/engineering-team#586
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.