Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create table to display list of bundles #2560

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in the table that will be used on the bundles tab for the upcoming bundle analysis product.

GH codecov/engineering-team#1024

Note

Requires #2559

Notable Changes

  • Create new BundleTable component
  • Add BundleTable to BundleContent component
  • Create new function to format load time values

Screenshots

Screenshot 2024-02-02 at 13 14 22 Screenshot 2024-02-02 at 13 15 14

Copy link

codecov-public-qa bot commented Feb 2, 2024

Codecov Report

Merging #2560 (fd6cf6f) into main (890cf9c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         816      817    +1     
  Lines       10715    10743   +28     
  Branches     2727     2697   -30     
=======================================
+ Hits        10540    10568   +28     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...ndlesTab/BundleContent/BundleTable/BundleTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.29% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890cf9c...fd6cf6f. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         816      817    +1     
  Lines       10715    10743   +28     
  Branches     2745     2699   -46     
=======================================
+ Hits        10540    10568   +28     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...ndlesTab/BundleContent/BundleTable/BundleTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.29% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890cf9c...fd6cf6f. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (890cf9c) 98.36% compared to head (fd6cf6f) 98.37%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         816      817    +1     
  Lines       10715    10743   +28     
  Branches     2692     2732   +40     
=======================================
+ Hits        10540    10568   +28     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...ndlesTab/BundleContent/BundleTable/BundleTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.29% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890cf9c...fd6cf6f. Read the comment docs.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit fd6cf6f
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65c36558ca04af0008eaeb59
😎 Deploy Preview https://deploy-preview-2560--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (890cf9c) 98.37% compared to head (fd6cf6f) 98.37%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2560   +/-   ##
=====================================
  Coverage   98.37   98.37           
=====================================
  Files        816     817    +1     
  Lines      10715   10743   +28     
  Branches    2737    2697   -40     
=====================================
+ Hits       10540   10568   +28     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...ndlesTab/BundleContent/BundleTable/BundleTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.29% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890cf9c...fd6cf6f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2560.codecov.dev for your PR preview. Expires after 1 month automatically.

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-1024-create-table-to-display-list-of-bundles branch from 7347b28 to fd6cf6f Compare February 7, 2024 11:11
@nicholas-codecov nicholas-codecov merged commit 0c28b45 into main Feb 7, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-1024-create-table-to-display-list-of-bundles branch February 7, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants