Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't set default org if update default org is in progress #2741

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

Upon sign up and when user selects personal, it then momentarily redirects to an org selector view. This gives user perception of missing part of flow or broken.

closes: codecov/engineering-team#1385

Notable Changes

i can't reproduce locally, so nothing visual changed, this is a pure attempt.

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (8b631a5) to head (1f717c0).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.01%     
==========================================
  Files         871      871              
  Lines       12457    12461       +4     
  Branches     3242     3286      +44     
==========================================
+ Hits        12254    12257       +3     
- Misses        194      195       +1     
  Partials        9        9              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.16% <100.00%> (+0.03%) ⬆️
Pages 99.12% <ø> (-0.02%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b631a5...1f717c0. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (8b631a5) to head (1f717c0).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.01%     
==========================================
  Files         871      871              
  Lines       12457    12461       +4     
  Branches     3301     3286      -15     
==========================================
+ Hits        12254    12257       +3     
- Misses        194      195       +1     
  Partials        9        9              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.16% <100.00%> (+0.03%) ⬆️
Pages 99.12% <ø> (-0.02%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b631a5...1f717c0. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.01%     
==========================================
  Files         871      871              
  Lines       12457    12461       +4     
  Branches     3305     3309       +4     
==========================================
+ Hits        12254    12257       +3     
- Misses        194      195       +1     
  Partials        9        9              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.16% <100.00%> (+0.03%) ⬆️
Pages 99.12% <ø> (-0.02%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b631a5...1f717c0. Read the comment docs.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (8b631a5) to head (1f717c0).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2741     +/-   ##
=======================================
- Coverage   98.37   98.36   -0.01     
=======================================
  Files        871     871             
  Lines      12457   12461      +4     
  Branches    3282    3305     +23     
=======================================
+ Hits       12254   12257      +3     
- Misses       194     195      +1     
  Partials       9       9             
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.16% <100.00%> (+0.03%) ⬆️
Pages 99.12% <ø> (-0.02%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b631a5...1f717c0. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 3, 2024

Bundle Report

Changes will increase total bundle size by 21 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.45MB 21 bytes ⬆️

Copy link

codecov bot commented Apr 3, 2024

Bundle Report

Changes will increase total bundle size by 21 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.45MB 21 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 3, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
32c142d Wed, 03 Apr 2024 17:03:26 GMT Expired Expired
1f717c0 Mon, 08 Apr 2024 15:59:30 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it!

@RulaKhaled RulaKhaled merged commit c6f0a69 into main Apr 8, 2024
54 of 58 checks passed
@RulaKhaled RulaKhaled deleted the onboarding-bug branch April 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: after personal selection, org selection appears momentarily
3 participants