-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't set default org if update default org is in progress #2741
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.01%
==========================================
Files 871 871
Lines 12457 12461 +4
Branches 3242 3286 +44
==========================================
+ Hits 12254 12257 +3
- Misses 194 195 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2741 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.01%
==========================================
Files 871 871
Lines 12457 12461 +4
Branches 3301 3286 -15
==========================================
+ Hits 12254 12257 +3
- Misses 194 195 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2741 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.01%
==========================================
Files 871 871
Lines 12457 12461 +4
Branches 3305 3309 +4
==========================================
+ Hits 12254 12257 +3
- Misses 194 195 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
- Coverage 98.37 98.36 -0.01
=======================================
Files 871 871
Lines 12457 12461 +4
Branches 3282 3305 +23
=======================================
+ Hits 12254 12257 +3
- Misses 194 195 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 21 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 21 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try it!
Description
Upon sign up and when user selects personal, it then momentarily redirects to an org selector view. This gives user perception of missing part of flow or broken.
closes: codecov/engineering-team#1385
Notable Changes
i can't reproduce locally, so nothing visual changed, this is a pure attempt.
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.