feat: Update with self hosted specific layout #2746
Conversation
Bundle ReportChanges will increase total bundle size by 1.5kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 1.5kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2746 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 871 873 +2
Lines 12461 12471 +10
Branches 3246 3246
=======================================
+ Hits 12258 12268 +10
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2746 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 871 873 +2
Lines 12461 12471 +10
Branches 3286 3310 +24
=======================================
+ Hits 12258 12268 +10
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2746 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 871 873 +2
Lines 12461 12471 +10
Branches 3309 3247 -62
=======================================
+ Hits 12258 12268 +10
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2746 +/- ##
=====================================
Coverage 98.37 98.37
=====================================
Files 871 873 +2
Lines 12461 12471 +10
Branches 3246 3306 +60
=====================================
+ Hits 12258 12268 +10
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Description
Intended changes in the API block access to owner and redirect user to /login if they are guests aka unauthenticated users.
We ran into an issue where base layout is calling unnecessary requests to owner in self hosted landing page causing infinite loop in login page if user is not authenticated already, this change creates a separate header/layout for the login page for self hosted, allowing users to access login page on guest mode.
Previous infinite loop caused by base layout:
Screen.Recording.2024-04-05.at.1.38.21.PM.mov
New changes:
Screen.Recording.2024-04-05.at.1.33.29.PM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.