Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete component measurements hook #2749

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

JerrySentry
Copy link
Contributor

A hook to be called when clicking on the trash can on the coverage over time for components tab.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2749   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         873      874    +1     
  Lines       12471    12488   +17     
  Branches     3306     3308    +2     
=======================================
+ Hits        12268    12285   +17     
  Misses        194      194           
  Partials        9        9           
Files Coverage Δ
...nentMeasurements/useDeleteComponentMeasurements.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.13% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68338fc...b91f091. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (68338fc) to head (b91f091).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2749   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         873      874    +1     
  Lines       12471    12488   +17     
  Branches     3306     3308    +2     
=======================================
+ Hits        12268    12285   +17     
  Misses        194      194           
  Partials        9        9           
Files Coverage Δ
...nentMeasurements/useDeleteComponentMeasurements.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.13% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68338fc...b91f091. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (68338fc) to head (b91f091).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2749   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         873      874    +1     
  Lines       12471    12488   +17     
  Branches     3287     3308   +21     
=======================================
+ Hits        12268    12285   +17     
  Misses        194      194           
  Partials        9        9           
Files Coverage Δ
...nentMeasurements/useDeleteComponentMeasurements.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.13% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68338fc...b91f091. Read the comment docs.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (68338fc) to head (b91f091).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2749   +/-   ##
=====================================
  Coverage   98.37   98.37           
=====================================
  Files        873     874    +1     
  Lines      12471   12488   +17     
  Branches    3306    3308    +2     
=====================================
+ Hits       12268   12285   +17     
  Misses       194     194           
  Partials       9       9           
Files Coverage Δ
...nentMeasurements/useDeleteComponentMeasurements.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.13% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68338fc...b91f091. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 5, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Apr 5, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 5, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
4c369a4 Fri, 05 Apr 2024 17:10:11 GMT Expired Expired
115be05 Fri, 05 Apr 2024 18:20:22 GMT Expired Expired
172deed Fri, 05 Apr 2024 18:58:05 GMT Expired Expired
f736fc7 Sat, 06 Apr 2024 02:16:15 GMT Expired Expired
b91f091 Mon, 08 Apr 2024 21:56:50 GMT Cloud Enterprise

@JerrySentry JerrySentry merged commit 6988fc0 into main Apr 8, 2024
59 checks passed
@JerrySentry JerrySentry deleted the apr_05_1376_delete_hook branch April 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants