-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: have components and flags tabs use the same constant file #2751
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 872 871 -1
Lines 12462 12457 -5
Branches 3242 3305 +63
==========================================
- Hits 12259 12254 -5
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
=====================================
Coverage 98.37 98.37
=====================================
Files 872 871 -1
Lines 12462 12457 -5
Branches 3301 3301
=====================================
- Hits 12259 12254 -5
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2751 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 872 871 -1
Lines 12462 12457 -5
Branches 3242 3305 +63
==========================================
- Hits 12259 12254 -5
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2751 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 872 871 -1
Lines 12462 12457 -5
Branches 3305 3301 -4
==========================================
- Hits 12259 12254 -5
Misses 194 194
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 120 bytes ⬇️
|
Bundle ReportChanges will decrease total bundle size by 120 bytes ⬇️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Refactor the constants.ts file containing measurements constants from components and flags to be at a shared space.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.