Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: have components and flags tabs use the same constant file #2751

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

JerrySentry
Copy link
Contributor

Refactor the constants.ts file containing measurements constants from components and flags to be at a shared space.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (6dc03f6) to head (4a2186f).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files         872      871       -1     
  Lines       12462    12457       -5     
  Branches     3242     3305      +63     
==========================================
- Hits        12259    12254       -5     
  Misses        194      194              
  Partials        9        9              
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 84.61% <ø> (ø)
src/pages/RepoPage/FlagsTab/Header/Header.jsx 100.00% <ø> (ø)
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.js 100.00% <ø> (ø)
src/pages/RepoPage/shared/constants.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.13% <ø> (-0.01%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc03f6...4a2186f. Read the comment docs.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (6dc03f6) to head (4a2186f).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2751   +/-   ##
=====================================
  Coverage   98.37   98.37           
=====================================
  Files        872     871    -1     
  Lines      12462   12457    -5     
  Branches    3301    3301           
=====================================
- Hits       12259   12254    -5     
  Misses       194     194           
  Partials       9       9           
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 84.61% <ø> (ø)
src/pages/RepoPage/FlagsTab/Header/Header.jsx 100.00% <ø> (ø)
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.js 100.00% <ø> (ø)
src/pages/RepoPage/shared/constants.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.13% <ø> (-0.01%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc03f6...4a2186f. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (6dc03f6) to head (4a2186f).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files         872      871       -1     
  Lines       12462    12457       -5     
  Branches     3242     3305      +63     
==========================================
- Hits        12259    12254       -5     
  Misses        194      194              
  Partials        9        9              
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 84.61% <ø> (ø)
src/pages/RepoPage/FlagsTab/Header/Header.jsx 100.00% <ø> (ø)
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.js 100.00% <ø> (ø)
src/pages/RepoPage/shared/constants.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.13% <ø> (-0.01%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc03f6...4a2186f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files         872      871       -1     
  Lines       12462    12457       -5     
  Branches     3305     3301       -4     
==========================================
- Hits        12259    12254       -5     
  Misses        194      194              
  Partials        9        9              
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 84.61% <ø> (ø)
src/pages/RepoPage/FlagsTab/Header/Header.jsx 100.00% <ø> (ø)
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.js 100.00% <ø> (ø)
src/pages/RepoPage/shared/constants.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.13% <ø> (-0.01%) ⬇️
Services 99.59% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc03f6...4a2186f. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 120 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.45MB 120 bytes ⬇️

Copy link

codecov bot commented Apr 5, 2024

Bundle Report

Changes will decrease total bundle size by 120 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 6.45MB 120 bytes ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 5, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
04d1289 Fri, 05 Apr 2024 18:48:56 GMT Expired Expired
4a2186f Fri, 05 Apr 2024 23:34:41 GMT Cloud Enterprise

@JerrySentry JerrySentry merged commit 8b631a5 into main Apr 5, 2024
54 of 58 checks passed
@JerrySentry JerrySentry deleted the apr_05_cot_constants branch April 5, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants