-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create branch selector for the components tab #2756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 873 874 +1
Lines 12471 12496 +25
Branches 3241 3289 +48
==========================================
+ Hits 12273 12297 +24
- Misses 191 192 +1
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
=====================================
Coverage 98.41 98.41
=====================================
Files 873 874 +1
Lines 12471 12496 +25
Branches 3241 3247 +6
=====================================
+ Hits 12273 12297 +24
- Misses 191 192 +1
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 873 874 +1
Lines 12471 12496 +25
Branches 3283 3247 -36
==========================================
+ Hits 12273 12297 +24
- Misses 191 192 +1
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 873 874 +1
Lines 12471 12496 +25
Branches 3301 3248 -53
==========================================
+ Hits 12273 12297 +24
- Misses 191 192 +1
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 1.35kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 1.35kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
New branch selector for components tab, will be used to reflect on the table.
Notable Changes
Create new branch selector, remove unnecessary feedback link as listed in https://www.figma.com/file/lpCAamL0oUGKvVng0g7vex/GH-234?type=design&node-id=21-787&mode=design&t=j3BVzL3ZezeeEYFB-0
Screenshots
Link to Sample Entry
closes: codecov/engineering-team#1381
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.