-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reflect new components schema #2757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
=====================================
Coverage 98.41 98.41
=====================================
Files 874 874
Lines 12496 12496
Branches 3247 3248 +1
=====================================
Hits 12297 12297
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2757 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12496
Branches 3307 3248 -59
=======================================
Hits 12297 12297
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2757 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12496
Branches 3312 3307 -5
=======================================
Hits 12297 12297
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12496
Branches 3248 3307 +59
=======================================
Hits 12297 12297
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
@@ -34,7 +34,7 @@ const dataReturned = { | |||
owner: { | |||
repository: { | |||
__typename: 'Repository', | |||
components: [ | |||
componentsYaml: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add the id
in the mock as well right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! good catch
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
We're adding termId for the search value for components, also rename to components yaml as it's a duplicate name under repository query.
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.