Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bundle select not updating list of bundles when changing branch #2765

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

I thought I had originally fixed this, but it seems to have creeped back in, this should fix the remaining issues with the bundle selector.

@codecov-staging
Copy link

codecov-staging bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12498    +2     
  Branches     3307     3313    +6     
=======================================
+ Hits        12297    12299    +2     
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d0dac...87060b5. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (f1d0dac) to head (87060b5).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12498    +2     
  Branches     3248     3247    -1     
=======================================
+ Hits        12297    12299    +2     
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d0dac...87060b5. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (f1d0dac) to head (87060b5).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12498    +2     
  Branches     3307     3247   -60     
=======================================
+ Hits        12297    12299    +2     
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d0dac...87060b5. Read the comment docs.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (f1d0dac) to head (87060b5).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2765   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        874     874           
  Lines      12496   12498    +2     
  Branches    3312    3308    -4     
=====================================
+ Hits       12297   12299    +2     
  Misses       192     192           
  Partials       7       7           
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d0dac...87060b5. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 10, 2024

Bundle Report

Changes will increase total bundle size by 101 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.45MB 101 bytes ⬆️

Copy link

codecov bot commented Apr 10, 2024

Bundle Report

Changes will increase total bundle size by 70 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.45MB 70 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 10, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
7a61dfd Wed, 10 Apr 2024 17:42:36 GMT Expired Expired
f4e0197 Thu, 11 Apr 2024 12:20:08 GMT Expired Expired
87060b5 Thu, 11 Apr 2024 12:39:02 GMT Expired Expired
87060b5 Thu, 11 Apr 2024 12:40:22 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov marked this pull request as ready for review April 11, 2024 12:29
@nicholas-codecov nicholas-codecov merged commit c3defcd into main Apr 11, 2024
59 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-another-small-change-to-the-bundle-selector branch April 11, 2024 12:48
RulaKhaled pushed a commit that referenced this pull request Apr 11, 2024
…nch (#2765)

Small fix to the update the bundles in the bundle selector on the bundles tab when changing branches.
RulaKhaled added a commit that referenced this pull request Apr 12, 2024
* feat: Move to components hook 3/3

* fix: Fix bundle select not updating list of bundles when changing branch (#2765)

Small fix to the update the bundles in the bundle selector on the bundles tab when changing branches.

* feat: Move to components hooks in components tab 1/? (#2763)

* update to components measurements

* backfilled banner update

---------

Co-authored-by: JerrySentry <[email protected]>

* feat: Update to use components hooks in components tab (#2766)

Co-authored-by: JerrySentry <[email protected]>

* it can be also null

* invalidate query

* last piece

---------

Co-authored-by: nicholas-codecov <[email protected]>
Co-authored-by: JerrySentry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants