-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix bundle select not updating list of bundles when changing branch #2765
fix: Fix bundle select not updating list of bundles when changing branch #2765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12498 +2
Branches 3307 3313 +6
=======================================
+ Hits 12297 12299 +2
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12498 +2
Branches 3248 3247 -1
=======================================
+ Hits 12297 12299 +2
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 874 874
Lines 12496 12498 +2
Branches 3307 3247 -60
=======================================
+ Hits 12297 12299 +2
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
=====================================
Coverage 98.41 98.41
=====================================
Files 874 874
Lines 12496 12498 +2
Branches 3312 3308 -4
=====================================
+ Hits 12297 12299 +2
Misses 192 192
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 101 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 70 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
…nch (#2765) Small fix to the update the bundles in the bundle selector on the bundles tab when changing branches.
* feat: Move to components hook 3/3 * fix: Fix bundle select not updating list of bundles when changing branch (#2765) Small fix to the update the bundles in the bundle selector on the bundles tab when changing branches. * feat: Move to components hooks in components tab 1/? (#2763) * update to components measurements * backfilled banner update --------- Co-authored-by: JerrySentry <[email protected]> * feat: Update to use components hooks in components tab (#2766) Co-authored-by: JerrySentry <[email protected]> * it can be also null * invalidate query * last piece --------- Co-authored-by: nicholas-codecov <[email protected]> Co-authored-by: JerrySentry <[email protected]>
Description
I thought I had originally fixed this, but it seems to have creeped back in, this should fix the remaining issues with the bundle selector.