-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 3/3 moving components tab to components hooks #2768
Conversation
…nch (#2765) Small fix to the update the bundles in the bundle selector on the bundles tab when changing branches.
* update to components measurements * backfilled banner update --------- Co-authored-by: JerrySentry <[email protected]>
Co-authored-by: JerrySentry <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.01%
==========================================
Files 874 874
Lines 12515 12507 -8
Branches 3312 3309 -3
==========================================
- Hits 12316 12310 -6
+ Misses 192 191 -1
+ Partials 7 6 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2768 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.01%
==========================================
Files 874 874
Lines 12515 12507 -8
Branches 3254 3314 +60
==========================================
- Hits 12316 12310 -6
+ Misses 192 191 -1
+ Partials 7 6 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
=======================================
+ Coverage 98.41 98.42 +0.01
=======================================
Files 874 874
Lines 12515 12507 -8
Branches 3295 3252 -43
=======================================
- Hits 12316 12310 -6
+ Misses 192 191 -1
+ Partials 7 6 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2768 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.01%
==========================================
Files 874 874
Lines 12515 12507 -8
Branches 3254 3251 -3
==========================================
- Hits 12316 12310 -6
+ Misses 192 191 -1
+ Partials 7 6 -1
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 3.38kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 3.38kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Moving to components hooks third PR.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.