[ref] Refactor commit detail file explorer table #2802

rohitvinnakota-codecov · 2024-04-23T16:32:14Z

Full refactor of the commit detail file explorer table and related hooks.

Also updated the CommitPathContents query to use the new repository endpoint.

Majority of the logic outside the table remains the same, and most changes are TS conversions.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov · 2024-04-23T16:34:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2802   +/-   ##
=====================================
  Coverage   98.47   98.47           
=====================================
  Files        871     872    +1     
  Lines      12686   12719   +33     
  Branches    3388    3412   +24     
=====================================
+ Hits       12492   12524   +32     
- Misses       190     191    +1     
  Partials       4       4

Files	Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <100.00%> (ø)`
...tailFileExplorer/CommitDetailFileExplorerTable.tsx	`100.00% <100.00%> (ø)`
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/commit/dir/constants.ts	`100.00% <100.00%> (ø)`
.../pathContents/commit/dir/useRepoCommitContents.tsx	`100.00% <100.00%> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
...able/TableEntries/CommitEntries/CommitDirEntry.tsx	`100.00% <100.00%> (ø)`
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx	`100.00% <100.00%> (ø)`
src/shared/treePaths/useCommitTreePath.js	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.27% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <100.00%> (+<0.01%)`	⬆️
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

codecov-staging · 2024-04-23T16:34:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage        ?   98.45%           
=======================================
  Files           ?      873           
  Lines           ?    12670           
  Branches        ?     3342           
=======================================
  Hits            ?    12474           
  Misses          ?      192           
  Partials        ?        4

Files	Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <100.00%> (ø)`
...tailFileExplorer/CommitDetailFileExplorerTable.tsx	`100.00% <100.00%> (ø)`
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/commit/dir/constants.ts	`100.00% <100.00%> (ø)`
.../pathContents/commit/dir/useRepoCommitContents.tsx	`100.00% <100.00%> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
...able/TableEntries/CommitEntries/CommitDirEntry.tsx	`100.00% <100.00%> (ø)`
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx	`100.00% <100.00%> (ø)`
src/shared/treePaths/useCommitTreePath.js	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (?)`
Layouts	`97.25% <ø> (?)`
Pages	`99.28% <100.00%> (?)`
Services	`99.56% <100.00%> (?)`
Shared	`99.84% <100.00%> (?)`
UI	`94.15% <ø> (?)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e9b4...bde1e11. Read the comment docs.

codecov-qa · 2024-04-23T16:34:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.01%     
==========================================
  Files         871      872       +1     
  Lines       12686    12719      +33     
  Branches     3388     3354      -34     
==========================================
+ Hits        12492    12524      +32     
- Misses        190      191       +1     
  Partials        4        4

Files	Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <100.00%> (ø)`
...tailFileExplorer/CommitDetailFileExplorerTable.tsx	`100.00% <100.00%> (ø)`
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/commit/dir/constants.ts	`100.00% <100.00%> (ø)`
.../pathContents/commit/dir/useRepoCommitContents.tsx	`100.00% <100.00%> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
...able/TableEntries/CommitEntries/CommitDirEntry.tsx	`100.00% <100.00%> (ø)`
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx	`100.00% <100.00%> (ø)`
src/shared/treePaths/useCommitTreePath.js	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.27% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <100.00%> (+<0.01%)`	⬆️
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

codecov-public-qa · 2024-04-23T16:34:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.01%     
==========================================
  Files         871      872       +1     
  Lines       12686    12719      +33     
  Branches     3371     3412      +41     
==========================================
+ Hits        12492    12524      +32     
- Misses        190      191       +1     
  Partials        4        4

Files	Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <100.00%> (ø)`
...tailFileExplorer/CommitDetailFileExplorerTable.tsx	`100.00% <100.00%> (ø)`
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/commit/dir/constants.ts	`100.00% <100.00%> (ø)`
.../pathContents/commit/dir/useRepoCommitContents.tsx	`100.00% <100.00%> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
...able/TableEntries/CommitEntries/CommitDirEntry.tsx	`100.00% <100.00%> (ø)`
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx	`100.00% <100.00%> (ø)`
src/shared/treePaths/useCommitTreePath.js	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.27% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <100.00%> (+<0.01%)`	⬆️
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

codecov-staging · 2024-04-23T16:37:43Z

Bundle Report

Changes will increase total bundle size by 82.06kB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.56MB	82.06kB ⬆️

codecov · 2024-04-23T16:38:36Z

Bundle Report

Changes will increase total bundle size by 82.06kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.56MB	82.06kB ⬆️

codecov-releaser · 2024-04-23T16:41:35Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit	Created	Cloud	Enterprise
`f6687f6`	Tue, 23 Apr 2024 16:41:35 GMT	Expired	Expired
`ee18087`	Tue, 23 Apr 2024 17:28:40 GMT	Expired	Expired
`575e3ef`	Tue, 23 Apr 2024 17:46:49 GMT	Expired	Expired
`9f12b6f`	Tue, 23 Apr 2024 18:05:53 GMT	Expired	Expired
`727146d`	Tue, 23 Apr 2024 18:42:14 GMT	Expired	Expired
`c7043e6`	Tue, 23 Apr 2024 19:10:01 GMT	Expired	Expired
`ee9e4ca`	Tue, 23 Apr 2024 19:33:45 GMT	Expired	Expired
`17ad2e7`	Thu, 25 Apr 2024 14:25:09 GMT	Expired	Expired
`17ad2e7`	Thu, 25 Apr 2024 14:26:11 GMT	Expired	Expired
`c82e755`	Thu, 25 Apr 2024 14:50:08 GMT	Expired	Expired
`a705cd6`	Mon, 29 Apr 2024 17:51:37 GMT	Expired	Expired
`a705cd6`	Mon, 29 Apr 2024 17:59:37 GMT	Cloud	Enterprise

…hub.com/codecov/gazebo into rvinnakota/refactor-commitdetailfileexp

spalmurray-codecov

Looks good! I think probably best that I reviewed this lol. Pretty much identical to the other two we did 😄

I tested locally as well, everything seems to be working as expected.

initial commit

f6687f6

rohitvinnakota-codecov and others added 13 commits April 23, 2024 13:18

fix params

ee18087

test with some console logs

575e3ef

update scehma

9f12b6f

update schema

727146d

move off of repo deprecated

c7043e6

do not use username

ee9e4ca

conversions and tests wip

d61c88e

wip 2

c1ad772

wip 3

a025df8

all tests

9a9388c

Merge branch 'main' into rvinnakota/refactor-commitdetailfileexp

e4183dd

update tree paths

a99f0ce

Add extra test

fc44002

rohitvinnakota-codecov marked this pull request as ready for review April 24, 2024 15:50

rohitvinnakota-codecov and others added 4 commits April 24, 2024 15:18

Merge branch 'main' into rvinnakota/refactor-commitdetailfileexp

45b81c6

Update test desc

896b81c

Merge branch 'rvinnakota/refactor-commitdetailfileexp' of https://git…

17ad2e7

…hub.com/codecov/gazebo into rvinnakota/refactor-commitdetailfileexp

Move things to useMemo

c82e755

spalmurray-codecov approved these changes Apr 29, 2024

View reviewed changes

rohitvinnakota-codecov added 2 commits April 29, 2024 13:33

Merge branch 'main' into rvinnakota/refactor-commitdetailfileexp

bde1e11

Merge branch 'main' into rvinnakota/refactor-commitdetailfileexp

a705cd6

rohitvinnakota-codecov merged commit ea4d427 into main Apr 29, 2024
49 of 51 checks passed

rohitvinnakota-codecov deleted the rvinnakota/refactor-commitdetailfileexp branch April 29, 2024 17:47

spalmurray-codecov mentioned this pull request May 8, 2024

BUG: search filter hidden when no results codecov/engineering-team#1575

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ref] Refactor commit detail file explorer table #2802

[ref] Refactor commit detail file explorer table #2802

rohitvinnakota-codecov commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

codecov-staging bot commented Apr 23, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Apr 23, 2024 •

edited

Loading

codecov-public-qa bot commented Apr 23, 2024 •

edited

Loading

codecov-staging bot commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

codecov-releaser commented Apr 23, 2024 •

edited

Loading

spalmurray-codecov left a comment

[ref] Refactor commit detail file explorer table #2802

[ref] Refactor commit detail file explorer table #2802

Conversation

rohitvinnakota-codecov commented Apr 23, 2024 • edited Loading

Legal Boilerplate

codecov bot commented Apr 23, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Apr 23, 2024 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Apr 23, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Apr 23, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Apr 23, 2024 • edited Loading

Bundle Report

codecov bot commented Apr 23, 2024 • edited Loading

Bundle Report

codecov-releaser commented Apr 23, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

spalmurray-codecov left a comment

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

codecov-staging bot commented Apr 23, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Apr 23, 2024 •

edited

Loading

codecov-public-qa bot commented Apr 23, 2024 •

edited

Loading

codecov-staging bot commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

codecov-releaser commented Apr 23, 2024 •

edited

Loading